Logging doesn't work properly in ChromiumCDMChild

RESOLVED FIXED in Firefox 55

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The logging in ChromiumCDMChild::OnSessionKeysChange() isn't properly logging the keyId; it's printing out a series of "%hX" instead of the keyId converted to hex.

e.g.:

2017-03-28 00:06:54.369000 UTC - [Main Thread]: D/GMP ChromiumCDMChild::OnSessionKeysChange(sid=B18F8D11FA2B742AC0DB4EF19DD3AFFC) keys={%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0,%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0,%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0}

I also had the string "WidevineVideoDecoder::Decode" in ChromiumCDMChild::RecvDecryptAndDecodeFrame(), which is misleading.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8851833 [details]
Bug 1351132 - Fix keystatus and decode logging in ChromiumCDMChild.

https://reviewboard.mozilla.org/r/124036/#review126554
Attachment #8851833 - Flags: review?(gsquelart) → review+

Comment 3

a year ago
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af6eb87cc3de
Fix keystatus and decode logging in ChromiumCDMChild. r=gerald

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/af6eb87cc3de
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.