Closed Bug 1351132 Opened 5 years ago Closed 5 years ago

Logging doesn't work properly in ChromiumCDMChild

Categories

(Core :: Audio/Video: GMP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file)

The logging in ChromiumCDMChild::OnSessionKeysChange() isn't properly logging the keyId; it's printing out a series of "%hX" instead of the keyId converted to hex.

e.g.:

2017-03-28 00:06:54.369000 UTC - [Main Thread]: D/GMP ChromiumCDMChild::OnSessionKeysChange(sid=B18F8D11FA2B742AC0DB4EF19DD3AFFC) keys={%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0,%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0,%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX%hX=0}

I also had the string "WidevineVideoDecoder::Decode" in ChromiumCDMChild::RecvDecryptAndDecodeFrame(), which is misleading.
Comment on attachment 8851833 [details]
Bug 1351132 - Fix keystatus and decode logging in ChromiumCDMChild.

https://reviewboard.mozilla.org/r/124036/#review126554
Attachment #8851833 - Flags: review?(gsquelart) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af6eb87cc3de
Fix keystatus and decode logging in ChromiumCDMChild. r=gerald
https://hg.mozilla.org/mozilla-central/rev/af6eb87cc3de
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.