Closed Bug 1351258 Opened 4 years ago Closed 4 years ago

Remove faststripe

Categories

(Toolkit :: Themes, enhancement)

Product:
Toolkit
Component:
Themes
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Bug 1351258 - Remove faststripe.
59 bytes, text/x-review-board-request
mossop
: review+
Details 
Comment on attachment 8852065 [details]
Bug 1351258 - Remove faststripe.

https://reviewboard.mozilla.org/r/124302/#review126968
Attachment #8852065 - Flags: review?(dtownsend) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s dc410fdbd015 -d a3b39ebdba02: rebasing 385673:dc410fdbd015 "Bug 1351258 - Remove faststripe. r=mossop" (tip)
merging old-configure.in
merging toolkit/themes/shared/non-mac.jar.inc.mn
warning: conflicts while merging toolkit/themes/shared/non-mac.jar.inc.mn! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment on attachment 8852065 [details]
Bug 1351258 - Remove faststripe.

https://reviewboard.mozilla.org/r/124302/#review126992

::: old-configure.in
(Diff revision 1)
>          ;;
>  esac
>  
>  case "${target}" in
>      *-android*|*-linuxandroid*)
> -        MOZ_THEME_FASTSTRIPE=1

What's the impact of this? Are you sure none of the files are used for $reason on android?
(In reply to Mike Hommey [:glandium] from comment #5)
> Comment on attachment 8852065 [details]
> Bug 1351258 - Remove faststripe.
> 
> https://reviewboard.mozilla.org/r/124302/#review126992
> 
> ::: old-configure.in
> (Diff revision 1)
> >          ;;
> >  esac
> >  
> >  case "${target}" in
> >      *-android*|*-linuxandroid*)
> > -        MOZ_THEME_FASTSTRIPE=1
> 
> What's the impact of this? Are you sure none of the files are used for
> $reason on android?

It has no effect. We use the "mobile" theme on Android:
http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/themes/moz.build#26-27
https://hg.mozilla.org/mozilla-central/rev/96c86fd1be39
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.