1351273 - Enable reftest and reftest-no-accel e10s debug tests on Win7 for TC

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Rob Thijssen [:grenade (EET/UTC+0300)]]

in bug 1351272 we disabled reftest, reftest-no-accel e10s debug tests, this bug is needed to make sure we don't forget that these tests shouldn't be disabled.

Comment 1

[Armen [:armenzg]]

I believe these are green already:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=97f9ea89ee800bbd849a22c6e8314082f96a7eb2&group_state=expanded&filter-searchStr=windows7-32%20reftest%20e10s%20debug

Should we enable them?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I just did some retriggers- I know these run on gpu instances, so I only did 4 retriggers, not 20 like I would prefer.  Assuming these start reasonable soon, we should have an answer in an hour- I would bet on 2-3 hours for an answer.

Possibly :grenade knows otherwise what would be holding us back?

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

so, when i was enabling tests, i disabled these because one or more chunk within the suite failed in a single try push. i didn't investigate why they had failed. just didn't want to have to deal with any orange tests as fallout from enabling the rest. since then, we learned that we were getting a number of intermittent failures because windows wasn't activated and was occasionally causing tests to lose focus when the windows activation dialog popped up. that issue has since been fixed and may have been the cause of the failures i saw. if they go green on your run, it's probably fine to re-enable them.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

ok, 5 of each of the R and Ru jobs are green, lets enable these!  closer to parity!

Comment 5

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: bug 1351273 - enable e10s: reftest, reftest-no-accel on tc win;

Review commit: https://reviewboard.mozilla.org/r/127612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127612/

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8855720 [details]
bug 1351273 - enable e10s: reftest, reftest-no-accel on tc win;

https://reviewboard.mozilla.org/r/127612/#review130336

thanks :grenade, you have done a lot of good work on this project :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/013c5a2a52cc
enable e10s: reftest, reftest-no-accel on tc win; r=jmaher

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/013c5a2a52cc