Closed
Bug 1351286
Opened 7 years ago
Closed 7 years ago
stylo: Intermittent tart | application crashed [@ nsHTMLStyleSheet::CalculateMappedServoDeclarations]
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: heycam)
Details
(Keywords: crash, intermittent-failure, Whiteboard: [stockwell fixed])
Attachments
(4 files)
Filed by: cbook [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=86944434&repo=mozilla-central https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-linux64-stylo/mozilla-central_ubuntu64_hw_stylo_test-svgr-bm104-tests1-linux-build1.txt.gz
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
heycam: can you take a look at this crash, thanks!
Flags: needinfo?(cam)
Keywords: crash
Comment hidden (Intermittent Failures Robot) |
Comment 4•7 years ago
|
||
Talos log (running locally)
Comment 5•7 years ago
|
||
Non-e10s version
Comment 6•7 years ago
|
||
this has hit our 30 failures/week threshold, :heycam, can you update any progress here or ask for others to help?
Whiteboard: [stockwell needswork]
Summary: Intermittent tart | application crashed [@ nsHTMLStyleSheet::CalculateMappedServoDeclarations] → stylo: Intermittent tart | application crashed [@ nsHTMLStyleSheet::CalculateMappedServoDeclarations]
Assignee | ||
Comment 7•7 years ago
|
||
Sorry Joel, I lost this needinfo in a backlog of email. My guess is that the crash is due to mDocument->GetShell() returning null in nsHTMLStyleSheet::CalculateMappedServoDeclarations. Since further up the stack there is an nsPresContext being notified of a pref change, which eventually calls into ProcessPendingRestyles on the style set for the same document, I'd further guess that GetShell() is returning null due to the document being in the bfcache. I guess we do want to process the restyles here...
Flags: needinfo?(cam)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=495b3c1b8e3016362f8555a7e1cc623f7ec443cd
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8856116 [details] Bug 1351286 - stylo: Make Servo mapped attributes mechanism cope with the document being in the bfcache. https://reviewboard.mozilla.org/r/128056/#review130638 r=dbaron, but could you file a followup bug on the fact that we really shouldn't be doing this work synchronously for pref changes when documents are in the bfcache. (Probably background tabs too!)
Attachment #8856116 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 11•7 years ago
|
||
Filed bug 1354873.
Comment 12•7 years ago
|
||
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b06bd4311713 stylo: Make Servo mapped attributes mechanism cope with the document being in the bfcache. r=dbaron
Updated•7 years ago
|
Whiteboard: [stockwell needswork] → [stockwell fixed]
Updated•7 years ago
|
Priority: -- → P1
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b06bd4311713
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Assignee: nobody → cam
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•