1351329 - Desktop notifications are appearing in the middle of the screen on Windows 10

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

As seen on Firefox Nightly 55.0a1 (2017-03-28) (64-bit) on Windows 10.

STR: Show a notification from https://people-mozilla.org/~mnoorenberghe/w3c_notifications.htm

Expected: Appears in the bottom right of screen
Actual: Appears in the middle of the screen

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Regressed from https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cc53710589fb500610495da5258b7b9221edf681&tochange=7ac8812719a11344a4cbcb5b1f6d55b5a68de0e6

Looks related to bug 1194751.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1351329 - Fix Windows implementation of defaultCSSScaleFactor.

Unlike contentsScaleFactor, defaultCSSScaleFactor always uses WinUtils::LogToPhysFactor regardless of the DPI awareness. Bug 1194751 broke the implementation (probably unknowingly).

Review commit: https://reviewboard.mozilla.org/r/124306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124306/

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8852068 [details]
Bug 1351329 - Fix Windows implementation of defaultCSSScaleFactor.

https://reviewboard.mozilla.org/r/124306/#review126866

Thanks! The original implemention does exactly this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3b39ebdba02
Fix Windows implementation of defaultCSSScaleFactor. r=kanru

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3b39ebdba02

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx55.0a1(2017-03-28), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx55.0b3, on Windows 10 x64.

Cheers!