Intermittent test_fallback_update.py TestFallbackUpdate.test_update | NoSuchWindowException: Unable to locate window

RESOLVED FIXED in Firefox -esr52

Status

Testing
Firefox UI Tests
RESOLVED FIXED
10 months ago
3 months ago

People

(Reporter: Treeherder Bug Filer, Assigned: whimboo)

Tracking

({intermittent-failure, regression})

Version 3
mozilla55
intermittent-failure, regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 wontfix, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: [stockwell fixed])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Comment 1

10 months ago
This regressed on central for the following range:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=Firefox%20&filter-tier=1&filter-tier=2&filter-tier=3&bugfiler&fromchange=7513b3f42058&tochange=01d1dedf400d

Child process with id "94150" has been marked as detached because it is no longer in the managed process group. Keeping reference to the process id "94157" which is the new child process.
Failed to gather test failure debug: Unable to locate window
stacktrace:
	WebDriverError@chrome://marionette/content/error.js:200:5
	NoSuchWindowError@chrome://marionette/content/error.js:402:5
	assert.that/<@chrome://marionette/content/assert.js:337:13
	assert.window@chrome://marionette/content/assert.js:136:10
	GeckoDriver.prototype.takeScreenshot@chrome://marionette/content/driver.js:2460:13
	Dispatcher.prototype.execute/req<@chrome://marionette/content/dispatcher.js:128:20
	TaskImpl_run@resource://gre/modules/Task.jsm:319:42
	TaskImpl@resource://gre/modules/Task.jsm:277:3
	asyncFunction@resource://gre/modules/Task.jsm:252:14
	Task_spawn@resource://gre/modules/Task.jsm:166:12
	Dispatcher.prototype.execute@chrome://marionette/content/dispatcher.js:118:13
	Dispatcher.prototype.onPacket@chrome://marionette/content/dispatcher.js:89:5
	_onJSONObjectReady/<@chrome://marionette/content/server.js -> resource://devtools/shared/transport/transport.js:483:11
	exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14
	exports.makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:101:14

TEST-UNEXPECTED-ERROR | test_fallback_update.py TestFallbackUpdate.test_update | NoSuchWindowException: Unable to locate window
Traceback (most recent call last):
  File "/Volumes/data/code/gecko/testing/marionette/harness/marionette_harness/marionette_test/testcases.py", line 166, in run
    testMethod()
  File "/Volumes/data/code/gecko/testing/firefox-ui/tests/update/fallback/test_fallback_update.py", line 21, in test_update
    self.download_and_apply_forced_update()
  File "/Volumes/data/code/gecko/testing/firefox-ui/harness/firefox_ui_harness/testcases.py", line 328, in download_and_apply_forced_update
    self.updates[self.current_update_index]['patch'] = self.patch_info
  File "/Volumes/data/code/gecko/testing/firefox-ui/harness/firefox_ui_harness/testcases.py", line 115, in patch_info
    patch = self.software_update.patch_info
  File "/Volumes/data/code/gecko/testing/marionette/puppeteer/firefox/firefox_puppeteer/api/software_update.py", line 293, in patch_info
    info = {'channel': self.update_channel}
  File "/Volumes/data/code/gecko/testing/marionette/puppeteer/firefox/firefox_puppeteer/api/software_update.py", line 319, in update_channel
    default_branch=True)
  File "/Volumes/data/code/gecko/testing/marionette/client/marionette_driver/marionette.py", line 1004, in get_pref
    """, script_args=(pref, default_branch, value_type))
  File "/Volumes/data/code/gecko/testing/marionette/client/marionette_driver/marionette.py", line 1798, in execute_script
    rv = self._send_message("executeScript", body, key="value")
  File "/Volumes/data/code/gecko/testing/marionette/client/marionette_driver/decorators.py", line 23, in _
    return func(*args, **kwargs)
  File "/Volumes/data/code/gecko/testing/marionette/client/marionette_driver/marionette.py", line 730, in _send_message
    self._handle_error(err)
  File "/Volumes/data/code/gecko/testing/marionette/client/marionette_driver/marionette.py", line 763, in _handle_error
    raise errors.lookup(error)(message, stacktrace=stacktrace)

It looks like a side-effect from my patch on bug 1322383.
Assignee: nobody → hskupin
Blocks: 1322383
Status: NEW → ASSIGNED
Keywords: regression
(Assignee)

Comment 2

10 months ago
The problem here is that we close the software update dialog once the complete mar file has been applied, and try to get the patch info afterward, which actually performs an execute_script() call against the closed window. As such we fail with no such window. To solve this we can simply leave it open because we restart anyway.
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
status-firefox52: --- → ?
status-firefox53: --- → affected
status-firefox54: --- → affected
status-firefox55: --- → affected
status-firefox-esr52: --- → affected

Comment 4

10 months ago
mozreview-review
Comment on attachment 8852380 [details]
Bug 1351335 - Don't close software update dialog before restart.

https://reviewboard.mozilla.org/r/124624/#review127164
Attachment #8852380 - Flags: review?(ato) → review+

Comment 5

10 months ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/805e9ae3b619
Don't close software update dialog before restart. r=ato

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/805e9ae3b619
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Comment 7

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/cff682712149
status-firefox54: affected → fixed
Flags: in-testsuite+

Comment 8

10 months ago
27 failures in 188 pushes (0.144 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-central: 24
* mozilla-aurora: 3

Platform breakdown:
* linux64: 6
* windows8-64: 4
* windows7-64: 4
* windows8-32: 3
* linux32: 3
* windows7-32: 2
* osx-10-9: 2
* osx-10-11: 2
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351335&startday=2017-03-29&endday=2017-03-29&tree=all
status-firefox52: ? → wontfix
status-firefox53: affected → fix-optional
status-firefox-esr52: affected → fix-optional
Whiteboard: [stockwell fixed]

Comment 9

10 months ago
298 failures in 845 pushes (0.353 failures/push) were associated with this bug in the last 7 days. 

This is the #1 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-aurora: 235
* mozilla-central: 63

Platform breakdown:
* windows8-64: 52
* windows7-64: 52
* linux64: 36
* linux32: 34
* windows8-32: 27
* windows7-32: 26
* osx-10-11: 25
* osx-10-10: 24
* osx-10-9: 22

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351335&startday=2017-03-27&endday=2017-04-02&tree=all
(Assignee)

Comment 10

10 months ago
This test-only patch will also stabilize the test on beta and esr52. Please uplift. Thanks.
Whiteboard: [stockwell fixed] → [stockwell fixed][checkin-needed-beta][checkin-needed-esr52]
(Assignee)

Comment 11

10 months ago
Given the complexity of the uplift, the right order and results are all layed out on bug 1322383.

Comment 12

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/a7cd0fc138fb
status-firefox53: fix-optional → fixed
Whiteboard: [stockwell fixed][checkin-needed-beta][checkin-needed-esr52] → [stockwell fixed]
(Assignee)

Comment 13

10 months ago
We also need this test-only patch uplifted to esr52.
Whiteboard: [stockwell fixed] → [stockwell fixed][checkin-needed-esr52]

Comment 14

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-esr52/rev/014a36bb27d8
status-firefox-esr52: fix-optional → fixed
Whiteboard: [stockwell fixed][checkin-needed-esr52] → [stockwell fixed]

Comment 15

4 months ago
1 failures in 943 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-esr52: 1

Platform breakdown:
* windowsxp: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351335&startday=2017-09-18&endday=2017-09-24&tree=all

Comment 16

4 months ago
6 failures in 885 pushes (0.007 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-esr52: 6

Platform breakdown:
* windows8-64: 3
* windows7-64: 2
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351335&startday=2017-09-25&endday=2017-10-01&tree=all

Comment 17

3 months ago
1 failures in 947 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-esr52: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351335&startday=2017-10-09&endday=2017-10-15&tree=all
You need to log in before you can comment on or make changes to this bug.