1351345 - Add test that a module loader does not attempt to re-instantiate a previously instantiated module

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jon Coppeard (:jonco)]

Attachment: add-module-reinstantiation-test

This adds a missing test that should have been added in bug 1284486.  This just exercises a different check inside ModuleDeclarationInstantiation().

Comment 1

[Shu-yu Guo [:shu]]

Comment on attachment 8852049 [details] [diff] [review]
add-module-reinstantiation-test

Review of attachment 8852049 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit-test/tests/modules/bug-1284486-2.js
@@ +4,5 @@
> +// time after a failure throws an error. Doing this would be a bug in the module
> +// loader, which is expected to throw away modules if there is an error
> +// instantiating them.
> +//
> +// The first attempt fails becuase module 'a' is not available. The second

typo: because

@@ +8,5 @@
> +// The first attempt fails becuase module 'a' is not available. The second
> +// attempt fails because of the previous failure (it would otherwise succeed as
> +// 'a' is now available).
> +//
> +// This test excerises the path where the previously instantiated module is

typo: exercises

::: js/src/jit-test/tests/modules/bug-1284486.js
@@ +9,5 @@
>  // attempt fails because of the previous failure (it would otherwise succeed as
>  // 'a' is now available).
> +//
> +// This test excerises the path where the previously instantiated module is
> +// encontered as an import.

typo: encountered

Comment 2

[Jon Coppeard (:jonco)]

Ugh, sorry for the typos.  Makes me wish we had something to spell check comments.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b9640274420
Add test that a module loader does not attempt to re-instantiate a previously instantiated module r=shu

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b9640274420