Closed Bug 1351418 Opened 3 years ago Closed 3 years ago

Single context menu item of checkbox breaks the context menu layout

Categories

(WebExtensions :: Frontend, defect, P2)

51 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla55
Blocking Flags:
webextensions +

People

(Reporter: jkt, Assigned: mattw)

References

Details

(Whiteboard: triaged)

Attachments

(3 files)

Attached image Selection_528.png
If I add a single context menu item with:

browser.contextMenus.create({
  id: "bloopy",
  title: "Always Open in This Container",
  type: "checkbox",
  checked: true,
  contexts: ["all"],
});

I get the attached behaviour in Ubuntu where the tick is underneath the icon of the extension itself.
Attached image Selection_529.png
Chrome decides to throw these into a submenu for checkbox type, so we should probably just do the same.
webextensions: --- → ?
Component: WebExtensions: Compatibility → WebExtensions: Frontend
Assignee: nobody → mwein
webextensions: ? → +
Priority: -- → P2
Whiteboard: triaged
See Also: → 1355642
Could you confirm if the same issue exists on ubuntu for radio buttons?
Flags: needinfo?(jkt)
Comment on attachment 8868730 [details]
Bug 1351418 - Put single checkbox items into submenu on linux

https://reviewboard.mozilla.org/r/140332/#review144290

Patch looks fine, try doesn't, but looking it doesn't appear to be related.
Attachment #8868730 - Flags: review?(mixedpuppy) → review+
Pushed by mwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2f2b634969f
Put single checkbox items into submenu on linux r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/e2f2b634969f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
Attachment #8868730 - Flags: review?(jkt)
Hmm not sure why removing myself as a reviewer removed the fixed status? Everything has been working fine with this I just wanted to clear out my ni and review flags. I can't seem to add the fixed status back.
Flags: needinfo?(jkt)
See Also: → 1492969
You need to log in before you can comment on or make changes to this bug.