1351418 - Single context menu item of checkbox breaks the context menu layout

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Jonathan Kingston [:jkt] he/him]

Attachment: Selection_528.png

If I add a single context menu item with:

browser.contextMenus.create({
  id: "bloopy",
  title: "Always Open in This Container",
  type: "checkbox",
  checked: true,
  contexts: ["all"],
});

I get the attached behaviour in Ubuntu where the tick is underneath the icon of the extension itself.

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Selection_529.png

Chrome decides to throw these into a submenu for checkbox type, so we should probably just do the same.

Comment 2

[Matthew Wein [:mattw]]

Could you confirm if the same issue exists on ubuntu for radio buttons?

Comment 3

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ddd956369231d995829a70aba058b52cb144203

Comment 4

[Matthew Wein [:mattw]]

Attachment: Bug 1351418 - Put single checkbox items into submenu on linux

Review commit: https://reviewboard.mozilla.org/r/140332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140332/

Comment 5

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=89a1725abe9b

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8868730 [details]
Bug 1351418 - Put single checkbox items into submenu on linux

https://reviewboard.mozilla.org/r/140332/#review144290

Patch looks fine, try doesn't, but looking it doesn't appear to be related.

Comment 7

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e6e95004f1ad37c60dce7fe73f2bfef7600ae06

Comment 8

[Matthew Wein [:mattw]]

Comment on attachment 8868730 [details]
Bug 1351418 - Put single checkbox items into submenu on linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140332/diff/1-2/

Comment 9

[Matthew Wein [:mattw]]

Comment on attachment 8868730 [details]
Bug 1351418 - Put single checkbox items into submenu on linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140332/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2f2b634969f
Put single checkbox items into submenu on linux r=mixedpuppy

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2f2b634969f

Comment 12

[Jonathan Kingston [:jkt] he/him]

Hmm not sure why removing myself as a reviewer removed the fixed status? Everything has been working fine with this I just wanted to clear out my ni and review flags. I can't seem to add the fixed status back.