59 bytes, text/x-review-board-request
If mozilla::image::DrawResult is going to be used in many places outside the imagelib code without namespace prefixing (which it already is), it should really have "Img" tacked on to the beginning of its name, or something. Given that this type is used extensively with generic drawing code, not having anything in its name to indicate this is specifically about the drawing of *images* under that generic drawing code makes it far to easy to misinterpret as a general drawing result. (See bug 1351440 for a case in point.) I think the string "Img" brings to mind the <img> element, which puts people on the right "assumption" path about what information this type is used to carry. That may be a bit overly specific, but it's better than looking like it's a very general thing to do with all painting.
2 years ago
Priority: -- → P3
If this has been decided upon (and this bug isnt more of a 'Hey we should consider this') I'm happy to trawl through and rename DrawResult and all the cases where its used.
Yeah, I think you can go ahead with this.
Does the file DrawResult.h need renaming too, or is it best to leave that be?
We should rename that too. If you are using hg you can use the command "hg move DrawResult.h ImgDrawResult.h" which will preserve blame information instead of just deleting all the lines and then re-adding them to a new file in the diff.
Attached commit updates all the instances of DrawResult to ImgDrawResult and renames the file DrawResult.h to ImgDrawResult.h. Compiles and runs fine on my Linux machine.
Comment on attachment 8936292 [details] Bug 1351447 - Rename imagelib's DrawResult to ImgDrawResult r+tnikkel https://reviewboard.mozilla.org/r/207028/#review212912
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8e33d0ce108c Rename imagelib's DrawResult to ImgDrawResult r=tnikkel
Backout by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c6340ede9772 Backed out changeset 8e33d0ce108c for failing /builds/worker/workspace/build/src/widget/cocoa/nsCocoaUtils on OS X r=backout a=backout on a CLOSED TREE
Backed out changeset 8e33d0ce108c (bug 1351447) for failing /builds/worker/workspace/build/src/widget/cocoa/nsCocoaUtils on OS X r=backout a=backout on a CLOSED TREE https://treeherder.mozilla.org/logviewer.html#?job_id=151241659&repo=autoland&lineNumber=17188 https://hg.mozilla.org/integration/autoland/rev/c6340ede9772df18d59f024d9acc5b5c01f14539 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8e33d0ce108cfbeb22dfafc9c5f57a233ec163db&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Looks like some renames were missed in OS X specific code.
Oops, not sure how I missed that. Made the change. I think I've jumped through the right hoops to push another review request.
I triggered a try push.
Comment on attachment 8936292 [details] Bug 1351447 - Rename imagelib's DrawResult to ImgDrawResult r+tnikkel https://reviewboard.mozilla.org/r/207028/#review213124
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4e2cf0afd644 Rename imagelib's DrawResult to ImgDrawResult r+tnikkel r=tnikkel
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.