1351467 - Permaorange on Win cgc testGCGrayMarking | CHECK failed: IsMarkedGray(value) when central merges to aurora on 2017-04-17

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Phil Ringnalda (:philor)]

e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=87005272&repo=try from https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9722ff493373f0b7918571e6f659ab6871e2518&selectedJob=87005272

[Tracking Requested - why for this release]: merge permaorange, closed tree, sadness.

Comment 1

[Marcia Knous [:marcia]]

Tracking 55+ for this potential permaorange.

Comment 2

[Jon Coppeard (:jonco)]

philor, how can I recreate this build to test?

Comment 3

[Phil Ringnalda (:philor)]

Locally? I'd start with just changing the a1 to a2 in the version number in config/milestone.txt and browser/config/version.txt since that does 99% of the changes, but if that doesn't work you can apply https://hg.mozilla.org/try/rev/611fd7a878de39fcf6da05416a68473edb8a5c4b which is the result of running the script releng runs to do the merge (the other one, https://hg.mozilla.org/try/rev/23a205bf9c12ce7120885e46010f283dfb70251a, shouldn't be needed even for a try push for cgc, it just tricks Try into doing PGO for the Windows browser builds).

Unless you meant "how do I build that shell variant?", in which case the log says "autospider.sh --platform win32 compacting" ought to do it.

Comment 4

[Jon Coppeard (:jonco)]

Attachment: aurora-build

Thanks.  With this patch I see test failures on Windows XP opt CGC builds - but with a different message:

TEST-PASS | testIntlAvailableLocales | ok
tSetting WINDOWSSDKDIR = c:/builds/moz2_slave/try_w32_sm-compacting-00000000/vs2015u3/SDK
Setting INCLUDE = c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\include;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\atlmfc\include;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\Include\10.0.14393.0\ucrt;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\Include\10.0.14393.0\shared;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\Include\10.0.14393.0\um;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\Include\10.0.14393.0\winrt;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\DIA SDK\include
Setting LIB = c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\lib;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\atlmfc\lib;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\lib\10.0.14393.0\ucrt\x86;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\lib\10.0.14393.0\um\x86;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\DIA SDK\lib
Setting PATH = c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\redist\x86\Microsoft.VC140.CRT;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\redist\x64\Microsoft.VC140.CRT;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\Redist\ucrt\DLLs\x86;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\Redist\ucrt\DLLs\x64;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\bin\amd64_x86;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\bin\amd64;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\VC\bin;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\bin\x86;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\SDK\bin\x64;c:\builds\moz2_slave\try_w32_sm-compacting-00000000\vs2015u3\DIA SDK\bin;c:\mozilla-build\nsis-3.0b1;c:\mozilla-build\nsis-2.46u;c:\mozilla-build\python27;c:\mozilla-build\buildbotve\scripts;C:\mozilla-build\msys\local\bin;c:\mozilla-build\wget;c:\mozilla-build\7zip;c:\mozilla-build\blat261\full;c:\mozilla-build\python;c:\mozilla-build\svn-win32-1.6.3\bin;c:\mozilla-build\upx203w;c:\mozilla-build\emacs-24.3\bin;c:\mozilla-build\info-zip;c:\mozilla-build\nsis-2.46u;c:\mozilla-build\nsis-3.0a2;c:\mozilla-build\wix-351728;c:\mozilla-build\hg;c:\mozilla-build\python\Scripts;c:\mozilla-build\kdiff3;c:\mozilla-build\yasm;c:\mozilla-build\mozmake;.;C:\mozilla-build\msys\local\bin;C:\mozilla-build\msys\mingw\bin;C:\mozilla-build\msys\bin;c:\Program Files (x86)\Puppet Labs\Puppet\puppet\bin;c:\Program Files (x86)\Puppet Labs\Puppet\facter\bin;c:\Program Files (x86)\Puppet Labs\Puppet\hiera\bin;c:\Program Files (x86)\Puppet Labs\Puppet\bin;c:\Program Files (x86)\Puppet Labs\Puppet\sys\ruby\bin;c:\Program Files (x86)\Puppet Labs\Puppet\sys\tools\bin;c:\Windows\system32;c:\Windows;c:\Windows\System32\Wbem;c:\Windows\System32\WindowsPowerShell\v1.0\;c:\Program Files\Amazon\cfn-bootstrap\;c:\Program Files (x86)\Windows Kits\8.0\Windows Performance Toolkit\;c:\Program Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files\Microsoft SQL Server\100\DTS\Binn\;c:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit\;c:\Program Files\Microsoft SQL Server\110\Tools\Binn\;c:\Program Files (x86)\Microsoft SDKs\TypeScript\1.0\;c:\Program Files (x86)\Puppet Labs\Puppet\bin;C:\mozilla-build\msys\bin;c:\mozilla-build\python27\scripts;c:\mozilla-build\wget;c:\mozilla-build\info-zip;c:\mozilla-build;c:\mozilla-build\vim\vim72;c:\mozilla-build\python27;c:\ProgramData\chocolatey\bin;.;c:\opt\runner;c:\mozilla-build\buildbotve;c:\mozilla-build\python27;C:\mozilla-build\msys\mingw\bin;C:\mozilla-build\msys\bin;C:\mozilla-build\msys\local\bin;.;C:\mozilla-build\msys\local\bin;c:\mozilla-build\moztools-x64\bin;c:\mozilla-build\vim\vim72
PROCESS-CRASH | jsapi-tests | application crashed
Return code: -1073741819
program finished with exit code -1073741819

Comment 5

[Phil Ringnalda (:philor)]

Fun, me too. I took one whole day off from pushing central-as-aurora to try, and somebody broke it both harder and ahead of your bustage.

Comment 6

[Phil Ringnalda (:philor)]

The crash is from bug 1331092, so you can get back to seeing this failure with either 'hg up -r efa3d9bfb312' or 'hg qbackout -sr 5e15fb883887:be699da69269'.

Comment 7

[Jon Coppeard (:jonco)]

I can still see this happening at this revision:

testGCGrayMarking
TEST-UNEXPECTED-FAIL | testGCGrayMarking | c:/builds/moz2_slave/try_w32_sm-compacting-00000000/src/js/src/jsapi-tests/testGCGrayMarking.cpp:181:CHECK failed: IsMarkedGray(value)

Comment 8

[Jon Coppeard (:jonco)]

Attachment: bug1351467-gray-marking-zeal

Oh this was dumb of me.  We need to disable GC zeal in this test because we have all these unrooted pointers around.  Try build still pending but this is surely the problem.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11fa5271d398
Disable GC zeal in testGCGrayMarking r=sfink

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11fa5271d398