1351486 - Remove unused nsPluginHost::e_SpecialTypeUnity

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Unused enum field

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1351486 - Remove unused nsPluginHost::eSpecialType_Unity;

Review commit: https://reviewboard.mozilla.org/r/124466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124466/

Comment 2

[Benjamin Smedberg]

Comment on attachment 8852237 [details]
Bug 1351486 - Remove unused nsPluginHost::eSpecialType_Unity;

https://reviewboard.mozilla.org/r/124466/#review127262

::: dom/plugins/base/nsPluginHost.h:202
(Diff revision 1)
> -                     eSpecialType_Test,
> +    eSpecialType_Test,
> -                     // Informs some decisions about OOP and quirks
> +    // Informs some decisions about OOP and quirks
> -                     eSpecialType_Flash,
> +    eSpecialType_Flash,
> -                     // Binds to the <applet> tag, has various special
> +    // Binds to the <applet> tag, has various special
> -                     // rules around opening channels, codebase, ...
> +    // rules around opening channels, codebase, ...
> -                     eSpecialType_Java,
> +    eSpecialType_Java

File a followup to remove all this special-casing also? Maybe we can completely neuter <applet> ?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64ec8261b704
Remove unused nsPluginHost::eSpecialType_Unity; r=bsmedberg

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/64ec8261b704