135161 - Review S/Mime UI text

Status: VERIFIED FIXED

(MailNews Core :: Security: S/MIME, defect, P3)

Description

[Kai Engert [:KaiE:]]

http://lxr.mozilla.org/mozilla/source/mailnews/extensions/smime/resources/locale/en-US/

Sean suggested we should review the wording in the above directory.

mcarlson already approved, but suggests we should be done with checking in the
changes by the end of the week.

Comment 1

[Sean Cotter]

Changes to am-smime.properties:

NoSenderSigningCert=You requested to digitally sign this message, but the
application failed to find the signing certificate you specified in your
Mail/News account preferences or the certificate has expired.

-->Change to: "You specified that this message should be digitally signed, but
the application either failed to find the signing certificate specified in your
Mail & Newsgroup Account Settings, or the certificate has expired."

NoSenderEncryptionCert=You requested to encrypt this message, but the
application failed to find the encryption certificate you specified in your
Mail/News account preferences or the certificate has expired.

-->Change to: "You specified encryption for this message, but the application
either failed to find the encryption certificate specified in your Mail &
Newsgroup Account Settings, or the certificate has expired."

MissingRecipientEncryptionCert=You requested to encrypt this message, but the
application failed to find an encryption cert for %S.

-->Change to: "You specified encryption for this message, but the application
failed to find an encryption certificate for %S"

SignNoSenderEncryptionCert=You requested to sign this message, but the
application failed to find an encryption cert to include in the signed message
or the certificate has expired.

-->Change to: "You specified that this message should be digitally signed, but
the application either failed to find an encryption certificate to include in
the signed message, or the certificate has expired."


Changes to msgReadSecurityInfo.dtd

<!ENTITY email.address "E-Mail address:">

-->Change to "Email address:"

Comment 2

[Jaime Rodriguez, Jr.]

In order to get an adt1.0.0+ there needs to be a patch with a review and super
review and the bug should be given an nsbeta1+.

Since mcarlson has given you permission to get these in this week, go ahead and
do the work.  Put the adt1.0.0 back on when you've done what I wrote above. 
Please get the patch ready as soon as possible.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Patch that changes what Sean suggested

Comment 4

[Sean Cotter]

one tiny correction: add a period after the %S for MissingRecipientEncryptionCert.

r=cotter

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Updated patch, dot added.

Comment 6

[Kai Engert [:KaiE:]]

Comment on attachment 77716 [details] [diff] [review]
Updated patch, dot added.

this patch has r=cotter

Comment 7

[Kai Engert [:KaiE:]]

Alec, can you please sr= ? (just 5 string changes).

Comment 8

[Alec Flett]

Comment on attachment 77716 [details] [diff] [review]
Updated patch, dot added.

sr=alecf

Comment 9

[Alec Flett]

Comment on attachment 77716 [details] [diff] [review]
Updated patch, dot added.

sr=alecf

Comment 10

[Kai Engert [:KaiE:]]

> In order to get an adt1.0.0+ there needs to be a patch with a review and super
> review and the bug should be given an nsbeta1+.

done, renominating

Comment 11

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin into 1.0.

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 77716 [details] [diff] [review]
Updated patch, dot added.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[Kai Engert [:KaiE:]]

checked in, fixed

Comment 14

[Charles Rosendahl]

Verified - please mark as 'fixed1.0.0' in the keyword section when when into the
1.0 branch.

Comment 15

[Charles Rosendahl]

I see this on the branch, I take it I can add the verified keyword?

Comment 16

[Kai Engert [:KaiE:]]

This landed before the 1.0.0 branch was created.