If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Intermittent js/src/jit-test/tests/asm.js/testBug1301191.js | Assertion failure: codeRange_->kind() == CodeRange::Function

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: aryx, Assigned: bbouvier)

Tracking

({assertion, intermittent-failure})

unspecified
mozilla55
assertion, intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

Attachments

(1 attachment)

https://treeherder.mozilla.org/logviewer.html#?job_id=87230066&repo=mozilla-inbound

[task 2017-03-29T10:05:15.619465Z] Assertion failure: codeRange_->kind() == CodeRange::Function, at /home/worker/workspace/build/src/js/src/wasm/WasmFrameIterator.cpp:81
[task 2017-03-29T10:05:15.619522Z] Exit code: -11
[task 2017-03-29T10:05:15.619556Z] FAIL - asm.js/testBug1301191.js
[task 2017-03-29T10:05:15.619708Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/asm.js/testBug1301191.js | Assertion failure: codeRange_->kind() == CodeRange::Function, at /home/worker/workspace/build/src/js/src/wasm/WasmFrameIterator.cpp:81 (code -11, args "--ion-eager --ion-offthread-compile=off")
[task 2017-03-29T10:05:15.619750Z] INFO exit-status     : -11
[task 2017-03-29T10:05:15.619787Z] INFO timed-out       : False
[task 2017-03-29T10:05:15.619881Z] INFO stderr         2> Assertion failure: codeRange_->kind() == CodeRange::Function, at /home/worker/workspace/build/src/js/src/wasm/WasmFrameIterator.cpp:81

Comment 1

6 months ago
So this assert was justified by the fact that we only call setResumePC() when containsFunctionPC(pc).  But what I think is happening here is that, in the case of the simulator, we'll interrupt at pc X, but then we let the simulator finish executing X before calling setResumePC on the new PC.  If X jumps to a stub, then the new PC won't be in function code.
(Assignee)

Comment 2

6 months ago
Created attachment 8852523 [details] [diff] [review]
patch.txt
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #8852523 - Flags: review?(luke)
(Assignee)

Updated

6 months ago
Attachment #8852523 - Attachment is patch: true

Comment 3

6 months ago
Comment on attachment 8852523 [details] [diff] [review]
patch.txt

Review of attachment 8852523 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8852523 - Flags: review?(luke) → review+
(Assignee)

Comment 4

6 months ago
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b79ec14c6a6dcd4be39b1bc44f02c06f6cef66

Comment 5

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f6b79ec14c6a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1334504
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.