1351660 - Intermittent js/src/jit-test/tests/asm.js/testBug1301191.js | Assertion failure: codeRange_->kind() == CodeRange::Function

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=87230066&repo=mozilla-inbound

[task 2017-03-29T10:05:15.619465Z] Assertion failure: codeRange_->kind() == CodeRange::Function, at /home/worker/workspace/build/src/js/src/wasm/WasmFrameIterator.cpp:81
[task 2017-03-29T10:05:15.619522Z] Exit code: -11
[task 2017-03-29T10:05:15.619556Z] FAIL - asm.js/testBug1301191.js
[task 2017-03-29T10:05:15.619708Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/asm.js/testBug1301191.js | Assertion failure: codeRange_->kind() == CodeRange::Function, at /home/worker/workspace/build/src/js/src/wasm/WasmFrameIterator.cpp:81 (code -11, args "--ion-eager --ion-offthread-compile=off")
[task 2017-03-29T10:05:15.619750Z] INFO exit-status     : -11
[task 2017-03-29T10:05:15.619787Z] INFO timed-out       : False
[task 2017-03-29T10:05:15.619881Z] INFO stderr         2> Assertion failure: codeRange_->kind() == CodeRange::Function, at /home/worker/workspace/build/src/js/src/wasm/WasmFrameIterator.cpp:81

Comment 1

[Luke Wagner [:luke]]

So this assert was justified by the fact that we only call setResumePC() when containsFunctionPC(pc).  But what I think is happening here is that, in the case of the simulator, we'll interrupt at pc X, but then we let the simulator finish executing X before calling setResumePC on the new PC.  If X jumps to a stub, then the new PC won't be in function code.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: patch.txt

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8852523 [details] [diff] [review]
patch.txt

Review of attachment 8852523 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b79ec14c6a6dcd4be39b1bc44f02c06f6cef66

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6b79ec14c6a