1351687 - Correct and Enable Oculus Pose Prediction

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[:kip (Kearwood Gilbert)]

Currently, pose prediction for Oculus is disabled behind a pref, dom.vr.poseprediction.enabled.  There was not much improvement or, in some cases, a reduction of comfort-level when enabling this pref.

The cause of incorrect pose prediction appears to be that we are passing a frame index to ovr_GetPredictedDisplayTime but "0" to ovr_SubmitFrame.  As we are only accessing the Oculus API from a single thread, we can simply pass "0" as a frame index to ovr_GetPredictedDisplayTime for correct functioning.

I suggest making this change and changing the default to enabling pose prediction.

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1351687 - Correct and Enable Pose Prediction for Oculus

Review commit: https://reviewboard.mozilla.org/r/125182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125182/

Comment 2

[:kip (Kearwood Gilbert)]

I tested this on very simple and very heavy models on SketchFab and webvr.info.

The improvement isn't greatly noticeable, but certainly is not making anything worse.

Comment 3

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8853106 [details]
Bug 1351687 - Correct and Enable Pose Prediction for Oculus

https://reviewboard.mozilla.org/r/125182/#review127874

LGTM

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b519e1798774
Correct and Enable Pose Prediction for Oculus r=daoshengmu

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b519e1798774