Closed Bug 1351834 Opened 4 years ago Closed 4 years ago

Set correct tab type when launching WepApp activity from external intent

Categories

(Firefox for Android Graveyard :: General, enhancement)

All
Android
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: JanH, Assigned: daleharvey)

References

Details

Attachments

(1 file)

This is basically a copy of the Custom Tabs approach (https://dxr.mozilla.org/mozilla-central/search?q=LOADURL_CUSTOMTAB):
- Define a LOADURL_WEBAPP flag
- Return it from the WebAppActivity in getNewTabFlags()
- Handle it in Tabs.java and set the correct tab type for the new tab
And of course check that this actually works - if WebAppActivities somehow open GeckoTabs through other mechanisms, then those need to be covered as well, so the new tab ends up with the correct tab type.
Blocks: 1347165
Ill take this if you arent planning to do it already?
Assignee: nobody → dale
I checked and this reports the tab correctly when I open new webapps
Attachment #8853653 - Flags: review?(jh+bugzilla)
The tabtype enum was left over I am guessing from a previous implementation, it doesnt look to be used
No, preparatory works from bug 1346004, which are slowly being brought into use now.
Comment on attachment 8853653 [details] [diff] [review]
Give webapp tabs correct type when launched

Review of attachment 8853653 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.
Attachment #8853653 - Flags: review?(jh+bugzilla) → review+
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/488c1b824092
Give webapp tabs correct type when launched. r=janh
https://hg.mozilla.org/mozilla-central/rev/488c1b824092
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.