Closed Bug 1351874 Opened 3 years ago Closed 3 years ago

ChromiumCDMProxy::Shutdown() fails to dispatch to ChromiumCDMParent::Shutdown

Categories

(Core :: Audio/Video: GMP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

In ChromiumCDMProxy::Shutdown() we set swap mCDM into a local reference in order to to null out mCDM, and then we dispatch a runnable to call Shutdown on the CDMParent. Unfortunately, we're dispatching to mCDM, which has been nulled out, rather than dispatching to the CDMParent instance that we swapped out.

https://dxr.mozilla.org/mozilla-central/rev/272ce6c2572164f5f6a9fba2a980ba9ccf50770c/dom/media/gmp/ChromiumCDMProxy.cpp#355

This causes shutdown leaks.
Comment on attachment 8852691 [details]
Bug 1351874 - Dispatch shutdown runnable to CDMParent rather than null.

https://reviewboard.mozilla.org/r/124866/#review127400

Sorry for not catching that in the initial review.
Attachment #8852691 - Flags: review?(gsquelart) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/891b2a73a6fc
Dispatch shutdown runnable to CDMParent rather than null. r=gerald
https://hg.mozilla.org/mozilla-central/rev/891b2a73a6fc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.