gfx scrollframe sets curpos before maxpos when going back

NEW
Unassigned

Status

()

17 years ago
2 years ago

People

(Reporter: mikepinkerton, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

when you go back/forward, we try to restore the previous scrollbar position. The
way the code does this however is a little skanky. It sets the curpos attribute
repeatedly during the page load but doesn't update the maxpos attribute until
it's totally done.

The problem with this is that this means that if it's communicating with a
native scrollbar, we're setting the curpos to greater than the maxpos for a
time. If things don't get cleaned up, this could render the native scrollbar
unusable depending on the impl of the native scrollbar.

Not a major issue, but makes it so that native scrollbar impls can't
sanity-check that curpos isn't greater than maxpos which could be dangerous.
blizzard might be interested in this if they use the new xbl->native scrollbar
stuff i just did.
happens on all operating systems
OS: Mac System 9.x → All

Updated

11 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets

Updated

9 years ago
Assignee: hyatt → nobody

Comment 3

2 years ago
Created attachment 8858193 [details] [diff] [review]
Hacky PeekReservedWord

This actually results in a small regression

Comment 4

2 years ago
Comment on attachment 8858193 [details] [diff] [review]
Hacky PeekReservedWord

Oops, wrong bugno.
Attachment #8858193 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.