Closed
Bug 1351910
Opened 8 years ago
Closed 8 years ago
Build more files as unified in ipc/glue
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
2.59 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
One file was excluded for using plarena which it did not. The other was
excluded for "clashes with strdup," it does not use strdup.
MozReview-Commit-ID: 5X5H9S4j903
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8852727 -
Flags: review?(wmccloskey)
Comment on attachment 8852727 [details] [diff] [review]
Build more files as unified in ipc/glue
Review of attachment 8852727 [details] [diff] [review]:
-----------------------------------------------------------------
Oddly, URIUtils.cpp didn't use strdup even when the original patch was checked in. But I guess it's easy to move this back if something goes wrong.
Attachment #8852727 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6933cdfb51860d1d3ac693240593fd41756ff780
Bug 1351910 - Build more files as unified in ipc/glue. r=billm
Backout by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5dbc3ffb11f
Backed out changeset 6933cdfb5186 for OSX bustage.
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/beac20cdb7366286a686ed0beea6cf2d70d03280
Bug 1351910 - Build more files as unified in ipc/glue. r=billm
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•