1351925 - Intermittent toolkit/content/tests/browser/browser_mediaPlayback_suspended_multipleAudio.js | The blocked audio can't be playback. - false == true -

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=87366295&repo=mozilla-central

https://queue.taskcluster.net/v1/task/BJUumPX7Sja8khGzsZfHqg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Alastor Wu [:alwu][PTO, back on 12/15]]

Close this bug because this issue didn't happen after 4/13.
Free feel to reopen this bug if you see this intermittent fail again.

https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351925&startday=2017-02-20&endday=2017-04-26&tree=all

Comment 2

[Intermittent Failures Robot]

21 failures in 892 pushes (0.024 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 10
* autoland: 8
* mozilla-central: 3

Platform breakdown:
* linux32: 11
* linux64: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351925&startday=2017-06-19&endday=2017-06-25&tree=all

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

while this is failing 21 times, keep in mind that this is only run during peak load once every 5th push, typically that means we are only seeing 25% of the possibly failures- I suspect the failure rate is 60-80 times in the last week if we ran this on every push.

This started up again on the 22nd, I just did some retriggers:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=linux x64 debug browser-chrome&tochange=6d631ae7ee675a4dff13cde60a8501191b3209ae&fromchange=1f6e4335dabb491e85ca1d89185a1e5d1ac04ca0&selectedJob=109019920

(most are bc3, but one instance is bc2)

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

and the retriggers point out that bug 1374930 is the root cause!

:jw_wang, as you are the patch author of bug 1374930, can you get a quick resolution (this week) on fixing this intermittent which seems to be a side effect of one of the patches?

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

I don't think this is a regression from bug 1374930:
1. bug 1374930 doesn't change audio channel code at all.
2. comment 1 indicates the issue went away without any fix.

So it is probably the code changes the timing to make it more likely to happen.

I added some logs for debugging:
https://public-artifacts.taskcluster.net/QHhAjxd4RVurixv_YBBeUw/0/public/logs/live_backing.log
https://hg.mozilla.org/try/rev/fa0162688950667449d6ddefc37562672dd83f86

JWW -- test 1
JWW Play(ErrorResult& aRv) mAudioChannelWrapper=0x7fe82b69c900
JWW IsTabActivated() ShouldBlockMedia=0
JWW IsPlaybackBlocked() IsTabActivated()
JWW PlayInternal()
JWW -- test 2

We should check why mAudioChannelAgent->ShouldBlockMedia() (which is expected to return true in this test) returns false in IsTabActivated().

Comment 6

[Alastor Wu [:alwu][PTO, back on 12/15]]

Will check it later.

Comment 7

[Alastor Wu [:alwu][PTO, back on 12/15]]

Attachment: Bug 1351925 - remove blockMedia() and related tests.

The intermittent failure is caused by the innate drawback of the present test,
it doesn't be consistent with the behavior how we actually block the media.

Since we always block media implicit, it would be set in nsGlobalWindow's ctor.
We would never call blockMedia directly, so we can remove the function.

Review commit: https://reviewboard.mozilla.org/r/152730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152730/

Comment 8

[Alastor Wu [:alwu][PTO, back on 12/15]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7211954c4ea74ddf8fed6df773b6a32938f6eeb1

Comment 9

[Andrea Marchesini [:baku]]

Comment on attachment 8881560 [details]
Bug 1351925 - remove blockMedia() and related tests.

https://reviewboard.mozilla.org/r/152730/#review158754

Comment 10

[Alastor Wu [:alwu][PTO, back on 12/15]]

Comment on attachment 8881560 [details]
Bug 1351925 - remove blockMedia() and related tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152730/diff/1-2/

Comment 11

[Alastor Wu [:alwu][PTO, back on 12/15]]

Rebase patch and push it to try again.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ef69747faf7b5f7b938a626c9ebc3777328feba

Comment 12

[Alastor Wu [:alwu][PTO, back on 12/15]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc9dff5d3e7fff163aa4c9f4b7f17273dedb7f26

Comment 13

[Alastor Wu [:alwu][PTO, back on 12/15]]

Comment on attachment 8881560 [details]
Bug 1351925 - remove blockMedia() and related tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152730/diff/2-3/

Comment 14

[Alastor Wu [:alwu][PTO, back on 12/15]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a1d6604ce140b975bcbd55ff43f2e6ceadf3bb0

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f803b2d8981
remove blockMedia() and related tests. r=baku

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2f803b2d8981

Comment 17

[Intermittent Failures Robot]

63 failures in 718 pushes (0.088 failures/push) were associated with this bug in the last 7 days. 

This is the #17 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 26
* autoland: 24
* mozilla-central: 7
* try: 4
* pine: 1
* oak: 1

Platform breakdown:
* linux32: 35
* linux64: 28

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1351925&startday=2017-06-26&endday=2017-07-02&tree=all

Comment 18

[Ryan VanderMeulen [:RyanVM]]

I don't see any occurrences of this failure on Beta for Fx55, but given the patch that landed, I figured I would at least check as to whether we want to let this ride the 56 train or nominate it for Beta approval for 55.

Comment 19

[Alastor Wu [:alwu][PTO, back on 12/15]]

Since this failure was triggered by bug1374930 which was only landed on FF56, I think we don't need to uplift this change to FF55.