Closed Bug 1351979 Opened 9 years ago Closed 9 years ago

Change CustomElementRegistry::Define code to properly propagate out JS exceptions

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

Patch, v1
1.36 KB, patch
wchen
: review+
Details | Diff | Splinter Review
So that the pending JS exception from JS_WrapValue and LifecycleCallbacks::Init calls [1] can be properly propagated out. [1] http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/dom/base/CustomElementRegistry.cpp#750
Attached patch Patch, v1 — — Splinter Review
Attachment #8852802 - Flags: review?(wchen)
Attachment #8852802 - Flags: review?(wchen) → review+
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/458d6fcb3b35 Change CustomElementRegistry::Define code to properly propagate out JS exceptions; r=wchen
https://hg.mozilla.org/mozilla-central/rev/458d6fcb3b35
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: