Closed
Bug 1351979
Opened 7 years ago
Closed 7 years ago
Change CustomElementRegistry::Define code to properly propagate out JS exceptions
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file)
|
1.36 KB,
patch
|
wchen
:
review+
|
Details | Diff | Splinter Review |
So that the pending JS exception from JS_WrapValue and LifecycleCallbacks::Init calls [1] can be properly propagated out. [1] http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/dom/base/CustomElementRegistry.cpp#750
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=32e44a3779c65e3fb3644e9112b558e4dc77ccbc&group_state=expanded&filter-tier=1
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8852802 -
Flags: review?(wchen)
|
||
Updated•7 years ago
|
Blocks: custom-elements-initial-release
|
||
Updated•7 years ago
|
Attachment #8852802 -
Flags: review?(wchen) → review+
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/458d6fcb3b35 Change CustomElementRegistry::Define code to properly propagate out JS exceptions; r=wchen
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/458d6fcb3b35
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•