Closed Bug 1352027 Opened 7 years ago Closed 4 years ago

Investigate simplifying SVGSVGElement::SetCurrentScaleTranslate for removal of SVGZoomEvent

Categories

(Core :: SVG, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: ayg, Unassigned)

References

Details

Bug 1314388 removes SVGZoomEvent.  The comment in SVGSVGElement::SetCurrentScaleTranslate suggests that a bunch of the code there is no longer needed:

   // IMPORTANT: If either mCurrentTranslate *or* mCurrentScale is changed then
   // mPreviousTranslate_x, mPreviousTranslate_y *and* mPreviousScale must all
   // be updated otherwise SVGZoomEvents will end up with invalid data. I.e. an
   // SVGZoomEvent's properties previousScale and previousTranslate must contain
   // the state of currentScale and currentTranslate immediately before the
   // change that caused the event's dispatch, which is *not* necessarily the
   // same thing as the values of currentScale and currentTranslate prior to
   // their own last change.

But I'm not sure if it's accurate, so I didn't try to actually remove it.
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1459905
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.