Closed Bug 1352030 Opened 7 years ago Closed 7 years ago

Assertion failure: aWindow->GetDocShell(), at Navigator.cpp:1916

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: cbook, Assigned: ehsan.akhgari)

References

(
URL
)

Details

(Keywords: assertion)

Attachments

(2 files)

crash stack
193.97 KB, text/plain
Details
Don't assert that a null docshell cannot be null
797 bytes, patch
baku
: review+
Details | Diff | Splinter Review
Attached file crash stack — 
Assertion failure: aWindow->GetDocShell(), at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/dom/base/Navigator.cpp:1916

found via bughunter topsite tests and reproduced on latest trunk windows build from tinderbox

Steps to reproduce:
-> Load http://www.techget.net
--> assertion failure within some seconds

related to bug  1347425 ?
ehsan, baku: can you take a look, thanks!
Flags: needinfo?(ehsan)
Flags: needinfo?(amarchesini)
I'm not sure why this assertion is needed really...  Taking it out seems to fix this bug.  :-)
Assignee: nobody → ehsan
Blocks: 1347425
Flags: needinfo?(ehsan)
Flags: needinfo?(amarchesini)

        Attachment #8852865 -
        Flags: review?(amarchesini)

        Attachment #8852865 -
        Flags: review?(amarchesini) → review+

    
    

    
  
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c31bcdef3bb
Don't assert that a null docshell cannot be null; r=baku

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6c31bcdef3bb
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox55:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: