1352084 - When 'mach android-emulator' fails, logging could be more verbose

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

I feel like I've gotten this error report a few times:

----
 0:00.36 Fetching and installing AVD. This may take a few minutes...
Error running mach:

    ['android-emulator', '--version', '7.0']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

OSError: [Errno 2] No such file or directory

  File "/home/brainbreaker/Firefox/src/mozilla-central/mobile/android/mach_commands.py", line 140, in emulator
    emulator.update_avd(force_update)
  File "/home/brainbreaker/Firefox/src/mozilla-central/testing/mozbase/mozrunner/mozrunner/devices/android_device.py", line 411, in update_avd
    self._update_avd_paths()
  File "/home/brainbreaker/Firefox/src/mozilla-central/testing/mozbase/mozrunner/mozrunner/devices/android_device.py", line 532, in _update_avd_paths
    os.rename(ini_file, ini_file_new)
----

or 

----
0:00.33 Starting Android emulator running Android 6.0 x86...
WARNING: Emulator has already completed!
WARNING: See log at /home/brainbreaker/.mozbuild/android-device/emulator.log for more information.
 0:10.35 Unable to verify that emulator is running.
 0:10.35 Use 'mach install' to install or update Firefox on your emulator.
----

In verbose mode, and maybe on error, I'd like to see info on OS, SDK versions, perhaps errors from the emulator log.

Comment 1

[Geoff Brown [:gbrown]]

Also, I'm a little worried that people are getting confused between arm and x86 emulators...let's remind them of what is what!

Comment 2

[Geoff Brown [:gbrown]]

And it would be really good if we could detect very old emulators and warn about trying to use those.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: various minor diagnostic improvements

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8854231 [details] [diff] [review]
various minor diagnostic improvements

Review of attachment 8854231 [details] [diff] [review]:
-----------------------------------------------------------------

nice patch- any concerns with autophone?

Comment 5

[Geoff Brown [:gbrown]]

No autophone concerns come to mind immediately, but that's a good thought...perhaps I'll open a parallel bug for that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4511c6164316
Improve debug logging for 'mach android-emulator'; r=jmaher

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4511c6164316