Closed
Bug 1352179
Opened 7 years ago
Closed 7 years ago
Remove redundant calls to loadJSContext().
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
Details
Attachments
(1 file)
|
16.55 KB,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
In a few places in the engine, we generate duplicate calls to loadJSContext(), because enterExitFrame() and enterFakeExitFrame() calls loadJSContext() internally and it's hard to notice that. For example:
> => 0x7cc44a55a81: movabs $0x7ffff694d008,%r11 <<<<<
> 0x7cc44a55a8b: mov (%r11),%rdi <<<<<
> 0x7cc44a55a8e: mov %rsp,0x7d8(%rdi)
> 0x7cc44a55a95: movabs $0x7fffedf74220,%r11
> 0x7cc44a55a9f: push %r11
> 0x7cc44a55aa1: pushq $0xda1de0
> 0x7cc44a55aa6: movabs $0x7ffff694d008,%r11 <<<<<
> 0x7cc44a55ab0: mov (%r11),%rdi <<<<<
It's a minor thing, but it's easy to fix the redundancy, so I did that.
Attachment #8853089 -
Flags: review?(tcampbell)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sstangl
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8853089 [details] [diff] [review] 0001-Bug-Remove-redundant-calls-to-loadJSContext-.-r.patch Review of attachment 8853089 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8853089 -
Flags: review?(tcampbell) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e65c7c94eae Remove redundant calls to loadJSContext(). r=tcampbell
Keywords: checkin-needed
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1e65c7c94eae
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•