1352199 - spinner of focused tab spins faster than spinners of background tabs in compact themes

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Asa Dotzler [:asa]]

The spinner of the focused tab spins faster than the spinners of background tabs. 

Tested on latest Windows nightly.

Comment 1

[Asa Dotzler [:asa]]

Just discovered that this only seems to happen in the Compact light and dark themes, not the default. Sorry. Subject updated.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

We are missing the SVG variants for these.

.tab-throbber[busy][progress] on compacttheme.css has:
list-style-image: url("chrome://browser/skin/compacttheme/[e-mail]");

http://searchfox.org/mozilla-central/rev/f668d2b2c1413452d536210b3ea2999eb81824f3/browser/themes/shared/compacttheme.inc.css#304-310

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

So the APNG is rotating and our CSS animation is rotating it too, which is why it's moving too fast.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1352199 - Invert the SVG loading throbber for selected tabs on compact themes.

Review commit: https://reviewboard.mozilla.org/r/125618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125618/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8853554 [details]
Bug 1352199 - Invert the SVG loading throbber for selected tabs on compact themes.

https://reviewboard.mozilla.org/r/125618/#review128224

::: browser/themes/shared/tabbrowser/loading.svg:17
(Diff revision 1)
> -  <path fill="#0077ff" fill-opacity=".15" d="M8,0A8,8,0,0,0,0,8a8,8,0,0,0,8,8,8,8,0,0,0,8-8A8,8,0,0,0,8,0ZM8,13A5,5,0,0,1,3,8,5,5,0,0,1,8,3a5,5,0,0,1,5,5A5,5,0,0,1,8,13Z"/>
> -  <path mask="url(#myMask)" fill="#0090ff" d="M8,3a5,5,0,0,1,5,5h0a1.5,1.5,0,0,0,3,0h0a8,8,0,1,0-.8,3.5l-2.7-1.3A5,5,0,1,1,8,3Z"/>
> +  <path fill="context-fill" fill-opacity=".15" d="M8,0A8,8,0,0,0,0,8a8,8,0,0,0,8,8,8,8,0,0,0,8-8A8,8,0,0,0,8,0ZM8,13A5,5,0,0,1,3,8,5,5,0,0,1,8,3a5,5,0,0,1,5,5A5,5,0,0,1,8,13Z"/>
> +  <path mask="url(#myMask)" fill="context-fill" d="M8,3a5,5,0,0,1,5,5h0a1.5,1.5,0,0,0,3,0h0a8,8,0,1,0-.8,3.5l-2.7-1.3A5,5,0,1,1,8,3Z"/>

I wasn't sure how to use context-fill here since we would be replacing two colors, though using #fff for the compact themes and #07f for all other places didn't seem much different than what are shipping today.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8853554 [details]
Bug 1352199 - Invert the SVG loading throbber for selected tabs on compact themes.

https://reviewboard.mozilla.org/r/125618/#review128260

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e86b8405b5f
Invert the SVG loading throbber for selected tabs on compact themes. r=dao

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2e86b8405b5f