1352200 - Win7 xpcshell 7 on TaskCluster fails with xpcshell return code: 0

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Armen [:armenzg]]

We're trying to green up some more Windows 7 jobs on the new CI called TaskCluster.

Mark, Jared, any suggestions on what this log might suggest the root of the failure is?

These jobs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=253b7b9da0f75142f4650d4fbce6d6ca45597e3e&filter-searchStr=Windows%207%20VM%20opt%20Xpcshell%20tests%20executed%20by%20TaskCluster%20test-windows7-32-vm%2Fopt-xpcshell-7%20tc-X(X7)&group_state=expanded

fail with little information:
> 15:08:58  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/modules/subprocess/test/xpcshell/test_subprocess.js | xpcshell return code: 0

I also this later on in the output:
15:08:58     INFO -  (xpcshell/head.js) | test run_next_test 22 pending (2)
15:08:58     INFO -  (xpcshell/head.js) | test test_subprocess_arguments finished (2)
15:08:58     INFO -  toolkit/modules/subprocess/test/xpcshell/test_subprocess.js | Starting test_subprocess_environment
15:08:58     INFO -  (xpcshell/head.js) | test test_subprocess_environment pending (2)
15:08:58     INFO -  (xpcshell/head.js) | test run_next_test 22 finished (2)
15:08:58     INFO -  PID 7168 | Traceback (most recent call last):
15:08:58     INFO -  PID 7168 |   File "Z:\\task_1490886049\\build\\venv\\lib\\site.py", line 703, in <module>
15:08:58     INFO -  PID 7168 |     main()
15:08:58     INFO -  PID 7168 |   File "Z:\\task_1490886049\\build\\venv\\lib\\site.py", line 683, in main
15:08:58     INFO -  PID 7168 |     paths_in_sys = addsitepackages(paths_in_sys)
15:08:58     INFO -  PID 7168 |   File "Z:\\task_1490886049\\build\\venv\\lib\\site.py", line 282, in addsitepackages
15:08:58     INFO -  PID 7168 |     addsitedir(sitedir, known_paths)
15:08:58     INFO -  PID 7168 |   File "Z:\\task_1490886049\\build\\venv\\lib\\site.py", line 204, in addsitedir
15:08:58     INFO -  PID 7168 |     addpackage(sitedir, name, known_paths)
15:08:58     INFO -  PID 7168 |   File "Z:\\task_1490886049\\build\\venv\\lib\\site.py", line 173, in addpackage
15:08:58     INFO -  PID 7168 |     exec(line)
15:08:58     INFO -  PID 7168 |   File "<string>", line 1, in <module>
15:08:58     INFO -  PID 7168 |   File "Z:\\task_1490886049\\build\\venv\\lib\\os.py", line 425, in __getitem__
15:08:58     INFO -  PID 7168 |     return self.data[key.upper()]
15:08:58     INFO -  PID 7168 | KeyError: 'PATH'
15:08:58     INFO -  Unexpected exception File closed at resource://gre/modules/subprocess/subprocess_worker_win.js:78

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Mark and I have only touched this test with minor syntax changes. Redirecting to Kris as he's been the majority maintainer of the test.

Comment 2

[Kris Maglione [:kmag]]

Hm. We already have that task disabled on XP because the python interpreter fails when we give it a partial environment. We can probably either try adding more variables to the environment until it works, or just stop running that task on Windows 7 too.

Comment 3

[Armen [:armenzg]]

Thank you kmag!

Comment 4

[Rob Thijssen [:grenade (EET/UTC+0300)]]

is this fixed? i note that xpcshell apears to be green on both win 7 and 10
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=xpcshell%20windows

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this looks to be fixed.