Closed
Bug 1352294
Opened 9 years ago
Closed 9 years ago
Sisyphus - Bughunter - remove raw addresses from signature buckets
Categories
(Testing Graveyard :: Sisyphus, enhancement)
Testing Graveyard
Sisyphus
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
Details
Attachments
(1 file)
|
2.28 KB,
patch
|
cbook
:
review+
|
Details | Diff | Splinter Review |
The use of raw addresses in signature buckets like
mozalloc_abort | mozalloc_handle_oom | moz_xmalloc xul.dll@0xcc48ed xul.dll@0x1622aee xul.dll@0xcc2014 xul.dll@0x1622aee
Does not provide value. As in this case, this typically occurs in out of memory situations where there is not enough memory to actually create the stack using symbols and the raw address is random. This leads to the creation of distinct buckets which have no intrinsic value. By eliminating the raw addresses we can group related crashes better. For example, we would use
mozalloc_abort | mozalloc_handle_oom | moz_xmalloc xul.dll xul.dll xul.dll xul.dll
The extra xul.dll's aren't that useful but they do show the depth of the stack and I think are ok to leave in.
| Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8853225 -
Flags: review?(cbook)
Comment 2•9 years ago
|
||
Comment on attachment 8853225 [details] [diff] [review]
crashaddresses.patch
yeah makes sense! thanks Bob!
Attachment #8853225 -
Flags: review?(cbook) → review+
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•