Closed
Bug 1352317
Opened 7 years ago
Closed 7 years ago
Output the kind of string (flat, inline, external, etc) in JS_GetTraceThingInfo
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
2.69 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
it would be nice to show the kind of strings in gc-edges log, to see what kind of string is taking much spaces or has duplication. I have draft patch that adds some information. I'll attach it after making it more readable.
|
Assignee | |
Comment 1•7 years ago
|
||
like current "rope: ", added the following labels: * "linear: " * "external: " * "dependent: " * "flat: " * "inline: " * "fat inline: " * "undepended: " * "extensible: " * "atom: " * "permanent atom: "
Attachment #8854396 -
Flags: review?(jdemooij)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8854396 [details] [diff] [review] Output the kind of string in gc edges log. Review of attachment 8854396 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8854396 -
Flags: review?(jdemooij) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/02b94db5f51c Output the kind of string in gc edges log. r=jandem
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/02b94db5f51c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•