Bug 1352319

Convert some use of int64_t for microseconds to TimeUnit in MDSM

RESOLVED FIXED in Firefox 55

Get help with this page

Status

()

Product:

Component:

Importance:

normal

Status:

RESOLVED FIXED

Reported:

2 years ago

Modified:

2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

Version:

unspecified

Target:

mozilla55

Points:

---

Blocks:

1245019

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(12 attachments)

Bug 1352319. P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P2 - rename variables and fix comments. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P3 - use TimeUnit in HasLowBufferedData(). 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal(). 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition(). 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P9 - let GetMediaTime() return a TimeUnit. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P10 - let GetClock() return a TimeUnit. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details
Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit. 2 years ago JW Wang [:jwwang] [:jw_wang] 59 bytes, text/x-review-board-request	kaku : review+	Details

JW Wang [:jwwang] [:jw_wang]

(Assignee)

Description

•

2 years ago

A step into bug 1245019.

JW Wang [:jwwang] [:jw_wang]

(Assignee)

Updated

•

2 years ago

Assignee: nobody → jwwang

Blocks: 1245019

Priority: -- → P3

Comment hidden (mozreview-request)

Created attachment 8853263 [details]
Bug 1352319. P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it.

Review commit: https://reviewboard.mozilla.org/r/125334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125334/

Comment hidden (mozreview-request)

Created attachment 8853264 [details]
Bug 1352319. P2 - rename variables and fix comments.

Review commit: https://reviewboard.mozilla.org/r/125336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125336/

Comment hidden (mozreview-request)

Created attachment 8853265 [details]
Bug 1352319. P3 - use TimeUnit in HasLowBufferedData().

Review commit: https://reviewboard.mozilla.org/r/125338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125338/

Comment hidden (mozreview-request)

Created attachment 8853266 [details]
Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState.

Review commit: https://reviewboard.mozilla.org/r/125340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125340/

Comment hidden (mozreview-request)

Created attachment 8853267 [details]
Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125342/

Comment hidden (mozreview-request)

Created attachment 8853268 [details]
Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125344/

Comment hidden (mozreview-request)

Created attachment 8853269 [details]
Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal().

Review commit: https://reviewboard.mozilla.org/r/125346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125346/

Comment hidden (mozreview-request)

Created attachment 8853270 [details]
Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition().

Review commit: https://reviewboard.mozilla.org/r/125348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125348/

Comment hidden (mozreview-request)

Created attachment 8853271 [details]
Bug 1352319. P9 - let GetMediaTime() return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125350/

Comment hidden (mozreview-request)

Created attachment 8853272 [details]
Bug 1352319. P10 - let GetClock() return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125352/

Comment hidden (mozreview-request)

Created attachment 8853273 [details]
Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125354/

Comment hidden (mozreview-request)

Created attachment 8853274 [details]
Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125356/

JW Wang [:jwwang] [:jw_wang]

(Assignee)

Updated

•

2 years ago

Attachment #8853263 - Flags: review?(kaku)

Attachment #8853264 - Flags: review?(kaku)

Attachment #8853265 - Flags: review?(kaku)

Attachment #8853266 - Flags: review?(kaku)

Attachment #8853267 - Flags: review?(kaku)

Attachment #8853268 - Flags: review?(kaku)

Attachment #8853269 - Flags: review?(kaku)

Attachment #8853270 - Flags: review?(kaku)

Attachment #8853271 - Flags: review?(kaku)

Attachment #8853272 - Flags: review?(kaku)

Attachment #8853273 - Flags: review?(kaku)

Attachment #8853274 - Flags: review?(kaku)

Tzuhao Kuo [:kaku]

Comment 13

•

2 years ago

mozreview-review

Comment on attachment 8853263 [details]
Bug 1352319. P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it.

https://reviewboard.mozilla.org/r/125334/#review127932

Attachment #8853263 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 14

•

2 years ago

mozreview-review

Comment on attachment 8853264 [details]
Bug 1352319. P2 - rename variables and fix comments.

https://reviewboard.mozilla.org/r/125336/#review127936

Attachment #8853264 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 15

•

2 years ago

mozreview-review

Comment on attachment 8853265 [details]
Bug 1352319. P3 - use TimeUnit in HasLowBufferedData().

https://reviewboard.mozilla.org/r/125338/#review127940

::: dom/media/MediaDecoderStateMachine.h:365
(Diff revision 1)
>  
>  
>    // Returns true if we're running low on buffered data.
>    bool HasLowBufferedData();
>  
>    // Returns true if we have less than aUsecs of buffered data available.

Please modify the comment accordingly. aUsecs -> aThreshold.

Attachment #8853265 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 16

•

2 years ago

mozreview-review

Comment on attachment 8853266 [details]
Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState.

https://reviewboard.mozilla.org/r/125340/#review127942

Attachment #8853266 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 17

•

2 years ago

mozreview-review

Comment on attachment 8853267 [details]
Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit.

https://reviewboard.mozilla.org/r/125342/#review127944

Attachment #8853267 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 18

•

2 years ago

mozreview-review

Comment on attachment 8853268 [details]
Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit.

https://reviewboard.mozilla.org/r/125344/#review127948

Attachment #8853268 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 19

•

2 years ago

mozreview-review

Comment on attachment 8853269 [details]
Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal().

https://reviewboard.mozilla.org/r/125346/#review127950

Attachment #8853269 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 20

•

2 years ago

mozreview-review

Comment on attachment 8853270 [details]
Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition().

https://reviewboard.mozilla.org/r/125348/#review127952

Attachment #8853270 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 21

•

2 years ago

mozreview-review

Comment on attachment 8853271 [details]
Bug 1352319. P9 - let GetMediaTime() return a TimeUnit.

https://reviewboard.mozilla.org/r/125350/#review127954

Attachment #8853271 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 22

•

2 years ago

mozreview-review

Comment on attachment 8853272 [details]
Bug 1352319. P10 - let GetClock() return a TimeUnit.

https://reviewboard.mozilla.org/r/125352/#review127956

Attachment #8853272 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 23

•

2 years ago

mozreview-review

Comment on attachment 8853273 [details]
Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit.

https://reviewboard.mozilla.org/r/125354/#review127958

Attachment #8853273 - Flags: review?(kaku) → review+

Tzuhao Kuo [:kaku]

Comment 24

•

2 years ago

mozreview-review

Comment on attachment 8853274 [details]
Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit.

https://reviewboard.mozilla.org/r/125356/#review127960

Attachment #8853274 - Flags: review?(kaku) → review+

Comment hidden (mozreview-request)

Comment on attachment 8853265 [details]
Bug 1352319. P3 - use TimeUnit in HasLowBufferedData().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125338/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853266 [details]
Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125340/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853267 [details]
Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125342/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853268 [details]
Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125344/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853269 [details]
Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125346/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853270 [details]
Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125348/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853271 [details]
Bug 1352319. P9 - let GetMediaTime() return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125350/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853272 [details]
Bug 1352319. P10 - let GetClock() return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125352/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853273 [details]
Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125354/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8853274 [details]
Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125356/diff/1-2/

JW Wang [:jwwang] [:jw_wang]

(Assignee)

Comment 35

•

2 years ago

Thanks for the review!

Pulsebot

Comment 36

•

2 years ago

Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9061c0e73463
P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it. r=kaku
https://hg.mozilla.org/integration/autoland/rev/ec076b60d269
P2 - rename variables and fix comments. r=kaku
https://hg.mozilla.org/integration/autoland/rev/2b36d0b36649
P3 - use TimeUnit in HasLowBufferedData(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/82caa9318285
P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/75ea66072581
P5 - rename AudioPrerollUsecs and let it return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/67b7c5be82cf
P6 - let AudioEndTime/VideoEndTime return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/2534fc738fc6
P7 - use TimeUnit in UpdatePlaybackPositionInternal(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/75972bacb5cf
P8 - use TimeUnit in UpdatePlaybackPosition(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/1da247595a48
P9 - let GetMediaTime() return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/e58dc73396a9
P10 - let GetClock() return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/83cf99ea83df
P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/5ee60477d72f
P12 - let CalculateNewCurrentTime() return a TimeUnit. r=kaku

Carsten Book [:Tomcat]

Comment 37

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/9061c0e73463
https://hg.mozilla.org/mozilla-central/rev/ec076b60d269
https://hg.mozilla.org/mozilla-central/rev/2b36d0b36649
https://hg.mozilla.org/mozilla-central/rev/82caa9318285
https://hg.mozilla.org/mozilla-central/rev/75ea66072581
https://hg.mozilla.org/mozilla-central/rev/67b7c5be82cf
https://hg.mozilla.org/mozilla-central/rev/2534fc738fc6
https://hg.mozilla.org/mozilla-central/rev/75972bacb5cf
https://hg.mozilla.org/mozilla-central/rev/1da247595a48
https://hg.mozilla.org/mozilla-central/rev/e58dc73396a9
https://hg.mozilla.org/mozilla-central/rev/83cf99ea83df
https://hg.mozilla.org/mozilla-central/rev/5ee60477d72f

Status: NEW → RESOLVED

Last Resolved: 2 years ago

status-firefox55: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla55

You need to log in before you can comment on or make changes to this bug.