1352319 - Convert some use of int64_t for microseconds to TimeUnit in MDSM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

A step into bug 1245019.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it.

Review commit: https://reviewboard.mozilla.org/r/125334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125334/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P2 - rename variables and fix comments.

Review commit: https://reviewboard.mozilla.org/r/125336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125336/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P3 - use TimeUnit in HasLowBufferedData().

Review commit: https://reviewboard.mozilla.org/r/125338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125338/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState.

Review commit: https://reviewboard.mozilla.org/r/125340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125340/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125342/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125344/

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal().

Review commit: https://reviewboard.mozilla.org/r/125346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125346/

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition().

Review commit: https://reviewboard.mozilla.org/r/125348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125348/

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P9 - let GetMediaTime() return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125350/

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P10 - let GetClock() return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125352/

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125354/

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit.

Review commit: https://reviewboard.mozilla.org/r/125356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125356/

Comment 13

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853263 [details]
Bug 1352319. P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it.

https://reviewboard.mozilla.org/r/125334/#review127932

Comment 14

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853264 [details]
Bug 1352319. P2 - rename variables and fix comments.

https://reviewboard.mozilla.org/r/125336/#review127936

Comment 15

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853265 [details]
Bug 1352319. P3 - use TimeUnit in HasLowBufferedData().

https://reviewboard.mozilla.org/r/125338/#review127940

::: dom/media/MediaDecoderStateMachine.h:365
(Diff revision 1)
>  
>  
>    // Returns true if we're running low on buffered data.
>    bool HasLowBufferedData();
>  
>    // Returns true if we have less than aUsecs of buffered data available.

Please modify the comment accordingly. aUsecs -> aThreshold.

Comment 16

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853266 [details]
Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState.

https://reviewboard.mozilla.org/r/125340/#review127942

Comment 17

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853267 [details]
Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit.

https://reviewboard.mozilla.org/r/125342/#review127944

Comment 18

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853268 [details]
Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit.

https://reviewboard.mozilla.org/r/125344/#review127948

Comment 19

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853269 [details]
Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal().

https://reviewboard.mozilla.org/r/125346/#review127950

Comment 20

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853270 [details]
Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition().

https://reviewboard.mozilla.org/r/125348/#review127952

Comment 21

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853271 [details]
Bug 1352319. P9 - let GetMediaTime() return a TimeUnit.

https://reviewboard.mozilla.org/r/125350/#review127954

Comment 22

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853272 [details]
Bug 1352319. P10 - let GetClock() return a TimeUnit.

https://reviewboard.mozilla.org/r/125352/#review127956

Comment 23

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853273 [details]
Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit.

https://reviewboard.mozilla.org/r/125354/#review127958

Comment 24

[Tzuhao Kuo [:kaku]]

Comment on attachment 8853274 [details]
Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit.

https://reviewboard.mozilla.org/r/125356/#review127960

Comment 25

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853265 [details]
Bug 1352319. P3 - use TimeUnit in HasLowBufferedData().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125338/diff/1-2/

Comment 26

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853266 [details]
Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125340/diff/1-2/

Comment 27

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853267 [details]
Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125342/diff/1-2/

Comment 28

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853268 [details]
Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125344/diff/1-2/

Comment 29

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853269 [details]
Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125346/diff/1-2/

Comment 30

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853270 [details]
Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125348/diff/1-2/

Comment 31

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853271 [details]
Bug 1352319. P9 - let GetMediaTime() return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125350/diff/1-2/

Comment 32

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853272 [details]
Bug 1352319. P10 - let GetClock() return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125352/diff/1-2/

Comment 33

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853273 [details]
Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125354/diff/1-2/

Comment 34

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8853274 [details]
Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125356/diff/1-2/

Comment 35

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9061c0e73463
P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it. r=kaku
https://hg.mozilla.org/integration/autoland/rev/ec076b60d269
P2 - rename variables and fix comments. r=kaku
https://hg.mozilla.org/integration/autoland/rev/2b36d0b36649
P3 - use TimeUnit in HasLowBufferedData(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/82caa9318285
P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/75ea66072581
P5 - rename AudioPrerollUsecs and let it return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/67b7c5be82cf
P6 - let AudioEndTime/VideoEndTime return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/2534fc738fc6
P7 - use TimeUnit in UpdatePlaybackPositionInternal(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/75972bacb5cf
P8 - use TimeUnit in UpdatePlaybackPosition(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/1da247595a48
P9 - let GetMediaTime() return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/e58dc73396a9
P10 - let GetClock() return a TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/83cf99ea83df
P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit. r=kaku
https://hg.mozilla.org/integration/autoland/rev/5ee60477d72f
P12 - let CalculateNewCurrentTime() return a TimeUnit. r=kaku

Comment 37

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9061c0e73463
https://hg.mozilla.org/mozilla-central/rev/ec076b60d269
https://hg.mozilla.org/mozilla-central/rev/2b36d0b36649
https://hg.mozilla.org/mozilla-central/rev/82caa9318285
https://hg.mozilla.org/mozilla-central/rev/75ea66072581
https://hg.mozilla.org/mozilla-central/rev/67b7c5be82cf
https://hg.mozilla.org/mozilla-central/rev/2534fc738fc6
https://hg.mozilla.org/mozilla-central/rev/75972bacb5cf
https://hg.mozilla.org/mozilla-central/rev/1da247595a48
https://hg.mozilla.org/mozilla-central/rev/e58dc73396a9
https://hg.mozilla.org/mozilla-central/rev/83cf99ea83df
https://hg.mozilla.org/mozilla-central/rev/5ee60477d72f