Closed
Bug 1352319
Opened 7 years ago
Closed 7 years ago
Convert some use of int64_t for microseconds to TimeUnit in MDSM
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(12 files)
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
kaku
:
review+
|
Details |
A step into bug 1245019.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8853263 -
Flags: review?(kaku)
Attachment #8853264 -
Flags: review?(kaku)
Attachment #8853265 -
Flags: review?(kaku)
Attachment #8853266 -
Flags: review?(kaku)
Attachment #8853267 -
Flags: review?(kaku)
Attachment #8853268 -
Flags: review?(kaku)
Attachment #8853269 -
Flags: review?(kaku)
Attachment #8853270 -
Flags: review?(kaku)
Attachment #8853271 -
Flags: review?(kaku)
Attachment #8853272 -
Flags: review?(kaku)
Attachment #8853273 -
Flags: review?(kaku)
Attachment #8853274 -
Flags: review?(kaku)
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8853263 [details] Bug 1352319. P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it. https://reviewboard.mozilla.org/r/125334/#review127932
Attachment #8853263 -
Flags: review?(kaku) → review+
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8853264 [details] Bug 1352319. P2 - rename variables and fix comments. https://reviewboard.mozilla.org/r/125336/#review127936
Attachment #8853264 -
Flags: review?(kaku) → review+
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8853265 [details] Bug 1352319. P3 - use TimeUnit in HasLowBufferedData(). https://reviewboard.mozilla.org/r/125338/#review127940 ::: dom/media/MediaDecoderStateMachine.h:365 (Diff revision 1) > > > // Returns true if we're running low on buffered data. > bool HasLowBufferedData(); > > // Returns true if we have less than aUsecs of buffered data available. Please modify the comment accordingly. aUsecs -> aThreshold.
Attachment #8853265 -
Flags: review?(kaku) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8853266 [details] Bug 1352319. P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState. https://reviewboard.mozilla.org/r/125340/#review127942
Attachment #8853266 -
Flags: review?(kaku) → review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8853267 [details] Bug 1352319. P5 - rename AudioPrerollUsecs and let it return a TimeUnit. https://reviewboard.mozilla.org/r/125342/#review127944
Attachment #8853267 -
Flags: review?(kaku) → review+
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8853268 [details] Bug 1352319. P6 - let AudioEndTime/VideoEndTime return a TimeUnit. https://reviewboard.mozilla.org/r/125344/#review127948
Attachment #8853268 -
Flags: review?(kaku) → review+
Comment 19•7 years ago
|
||
mozreview-review |
Comment on attachment 8853269 [details] Bug 1352319. P7 - use TimeUnit in UpdatePlaybackPositionInternal(). https://reviewboard.mozilla.org/r/125346/#review127950
Attachment #8853269 -
Flags: review?(kaku) → review+
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8853270 [details] Bug 1352319. P8 - use TimeUnit in UpdatePlaybackPosition(). https://reviewboard.mozilla.org/r/125348/#review127952
Attachment #8853270 -
Flags: review?(kaku) → review+
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8853271 [details] Bug 1352319. P9 - let GetMediaTime() return a TimeUnit. https://reviewboard.mozilla.org/r/125350/#review127954
Attachment #8853271 -
Flags: review?(kaku) → review+
Comment 22•7 years ago
|
||
mozreview-review |
Comment on attachment 8853272 [details] Bug 1352319. P10 - let GetClock() return a TimeUnit. https://reviewboard.mozilla.org/r/125352/#review127956
Attachment #8853272 -
Flags: review?(kaku) → review+
Comment 23•7 years ago
|
||
mozreview-review |
Comment on attachment 8853273 [details] Bug 1352319. P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit. https://reviewboard.mozilla.org/r/125354/#review127958
Attachment #8853273 -
Flags: review?(kaku) → review+
Comment 24•7 years ago
|
||
mozreview-review |
Comment on attachment 8853274 [details] Bug 1352319. P12 - let CalculateNewCurrentTime() return a TimeUnit. https://reviewboard.mozilla.org/r/125356/#review127960
Attachment #8853274 -
Flags: review?(kaku) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 35•7 years ago
|
||
Thanks for the review!
Comment 36•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9061c0e73463 P1 - add LOW_BUFFER_THRESHOLD and replace the use of LOW_DATA_THRESHOLD_USECS with it. r=kaku https://hg.mozilla.org/integration/autoland/rev/ec076b60d269 P2 - rename variables and fix comments. r=kaku https://hg.mozilla.org/integration/autoland/rev/2b36d0b36649 P3 - use TimeUnit in HasLowBufferedData(). r=kaku https://hg.mozilla.org/integration/autoland/rev/82caa9318285 P4 - move AudioPrerollUsecs/VideoPrerollFrames into DecodingState. r=kaku https://hg.mozilla.org/integration/autoland/rev/75ea66072581 P5 - rename AudioPrerollUsecs and let it return a TimeUnit. r=kaku https://hg.mozilla.org/integration/autoland/rev/67b7c5be82cf P6 - let AudioEndTime/VideoEndTime return a TimeUnit. r=kaku https://hg.mozilla.org/integration/autoland/rev/2534fc738fc6 P7 - use TimeUnit in UpdatePlaybackPositionInternal(). r=kaku https://hg.mozilla.org/integration/autoland/rev/75972bacb5cf P8 - use TimeUnit in UpdatePlaybackPosition(). r=kaku https://hg.mozilla.org/integration/autoland/rev/1da247595a48 P9 - let GetMediaTime() return a TimeUnit. r=kaku https://hg.mozilla.org/integration/autoland/rev/e58dc73396a9 P10 - let GetClock() return a TimeUnit. r=kaku https://hg.mozilla.org/integration/autoland/rev/83cf99ea83df P11 - change the type of NextFrameSeekingState::mCurrentTime to TimeUnit. r=kaku https://hg.mozilla.org/integration/autoland/rev/5ee60477d72f P12 - let CalculateNewCurrentTime() return a TimeUnit. r=kaku
Comment 37•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9061c0e73463 https://hg.mozilla.org/mozilla-central/rev/ec076b60d269 https://hg.mozilla.org/mozilla-central/rev/2b36d0b36649 https://hg.mozilla.org/mozilla-central/rev/82caa9318285 https://hg.mozilla.org/mozilla-central/rev/75ea66072581 https://hg.mozilla.org/mozilla-central/rev/67b7c5be82cf https://hg.mozilla.org/mozilla-central/rev/2534fc738fc6 https://hg.mozilla.org/mozilla-central/rev/75972bacb5cf https://hg.mozilla.org/mozilla-central/rev/1da247595a48 https://hg.mozilla.org/mozilla-central/rev/e58dc73396a9 https://hg.mozilla.org/mozilla-central/rev/83cf99ea83df https://hg.mozilla.org/mozilla-central/rev/5ee60477d72f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•