[Form Autofill] Edit profile dialog's cancel and save buttons should depend on OS

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Form Manager
P1
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: scottwu, Assigned: scottwu)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [form autofill:M2])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
The "Cancel" and "Save" buttons should be orders base on OS.

On Windows, the convention is to have "Save|Cancel".

On Mac and Linux, the convention is to have "Cancel|Save".
Comment hidden (mozreview-request)
Priority: -- → P1

Comment 2

a month ago
mozreview-review
Comment on attachment 8859121 [details]
Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows.

https://reviewboard.mozilla.org/r/131126/#review134146

Looks good.
Attachment #8859121 - Flags: review?(lchang) → review+

Comment 3

a month ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/debf5e53a136
Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang

Comment 4

a month ago
sorry had to back this out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=92557062&repo=autoland&lineNumber=20843
Flags: needinfo?(scwwu)
(Assignee)

Comment 5

a month ago
Thanks Iris. Sorry about that I'll look into the problem.
Flags: needinfo?(scwwu)

Comment 6

a month ago
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7207dd5cae8
Backed out changeset debf5e53a136 for build bustage
Comment hidden (mozreview-request)
(Assignee)

Comment 8

a month ago
The build failed because `skin/linux/editProfile.css` and `skin/osx/editProfile.css` are identical. Duplicated files should be listed in `browser/installer/allowed-dupes.mn`, but it also says we shouldn't add more:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/browser/installer/allowed-dupes.mn#5

I'm fixing this issue simply by adding comments to both css files for now, because they will likely be used very soon.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=81942d1dead9c5bf51555d8cb0209b0e85690f31

Comment 9

a month ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3864467a616c
Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang
https://hg.mozilla.org/mozilla-central/rev/3864467a616c
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.