1352331 - [Form Autofill] Edit profile dialog's cancel and save buttons should depend on OS

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P1)

Description

[Scott Wu [:scottwu]]

The "Cancel" and "Save" buttons should be orders base on OS.

On Windows, the convention is to have "Save|Cancel".

On Mac and Linux, the convention is to have "Cancel|Save".

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows.

Review commit: https://reviewboard.mozilla.org/r/131126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131126/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8859121 [details]
Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows.

https://reviewboard.mozilla.org/r/131126/#review134146

Looks good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/debf5e53a136
Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang

Comment 4

[Iris Hsiao [:ihsiao]]

sorry had to back this out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=92557062&repo=autoland&lineNumber=20843

Comment 5

[Scott Wu [:scottwu]]

Thanks Iris. Sorry about that I'll look into the problem.

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7207dd5cae8
Backed out changeset debf5e53a136 for build bustage

Comment 7

[Scott Wu [:scottwu]]

Comment on attachment 8859121 [details]
Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131126/diff/1-2/

Comment 8

[Scott Wu [:scottwu]]

The build failed because `skin/linux/editProfile.css` and `skin/osx/editProfile.css` are identical. Duplicated files should be listed in `browser/installer/allowed-dupes.mn`, but it also says we shouldn't add more:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/browser/installer/allowed-dupes.mn#5

I'm fixing this issue simply by adding comments to both css files for now, because they will likely be used very soon.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=81942d1dead9c5bf51555d8cb0209b0e85690f31

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3864467a616c
Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3864467a616c

Comment 11

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on 56.0a1 20170728100358 Windows 10x64/ Mac OSX 10.12 / Ubuntu 16.04.