Closed Bug 1352331 Opened 3 years ago Closed 3 years ago

[Form Autofill] Edit profile dialog's cancel and save buttons should depend on OS

Categories

(Toolkit :: Form Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla55
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- disabled
firefox55 --- fixed
firefox56 --- verified

People

(Reporter: scottwu, Assigned: scottwu)

References

Details

(Whiteboard: [form autofill:M2])

Attachments

(1 file)

The "Cancel" and "Save" buttons should be orders base on OS.

On Windows, the convention is to have "Save|Cancel".

On Mac and Linux, the convention is to have "Cancel|Save".
Priority: -- → P1
Comment on attachment 8859121 [details]
Bug 1352331 - Swap the cancel and save buttons on edit profile dialog for Windows.

https://reviewboard.mozilla.org/r/131126/#review134146

Looks good.
Attachment #8859121 - Flags: review?(lchang) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/debf5e53a136
Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang
sorry had to back this out for build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=92557062&repo=autoland&lineNumber=20843
Flags: needinfo?(scwwu)
Thanks Iris. Sorry about that I'll look into the problem.
Flags: needinfo?(scwwu)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7207dd5cae8
Backed out changeset debf5e53a136 for build bustage
The build failed because `skin/linux/editProfile.css` and `skin/osx/editProfile.css` are identical. Duplicated files should be listed in `browser/installer/allowed-dupes.mn`, but it also says we shouldn't add more:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/browser/installer/allowed-dupes.mn#5

I'm fixing this issue simply by adding comments to both css files for now, because they will likely be used very soon.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=81942d1dead9c5bf51555d8cb0209b0e85690f31
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3864467a616c
Swap the cancel and save buttons on edit profile dialog for Windows. r=lchang
https://hg.mozilla.org/mozilla-central/rev/3864467a616c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Verified as fixed on 56.0a1 20170728100358 Windows 10x64/ Mac OSX 10.12 / Ubuntu 16.04.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.