1352340 - Interdiff displays 2 the same moved-from-line anchors without corresponding moved-to-line.

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: DiffViewer, defect, P1)

Description

[Piotr Zalewa [:zalun]]

Taken from bug 1251455 Comment 3 • 10 months ago

I modified :Gijs comment to reflect what's fixed already. It's not possible now to link lines on the same sides, before right-hand side 220 was linked from right-hand-side 103.

Look at https://reviewboard.mozilla.org/r/56584/diff/4#17

Scroll down to line 76 on the right-hand-side of the diff. It says "moved from line 220". It is an inactive link.

However, if you scroll back up to what was line 220 on the *left-hand-side* of the diff, you will in fact find a line that looks the same. 

Another fun thing is that if you scroll down further than before, to line 103 on the right-hand-side, that *also* says "moved from line 220", for the same line, with the same problem on the link. Then on line 109 (right-hand-side), we see a pointer to line 219, again pointing to that line on the left-hand-side, for a 2-line hunk thus including line 220. :-\

The line pointers should go to the right line, and ideally there should be some indication that a line that occurred once in the old version of the file has now been duplicated thrice over (with the comment reproduced once).

Comment 1

[Piotr Zalewa [:zalun]]

I am now writing a test case and will update the upstream ticket [1]

[1] https://hellosplat.com/s/beanbag/tickets/4371/

Comment 2

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.