1352357 - Add leak checking support to wptrunner

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

Add support for leak checking to wptrunner using mozleak. This has to support disabling leak checking for specific (groups of) tests because imported tests may leak. Doing that requires restarting the browser.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1352357 - Add leak checking support for web-platform-tests,

Implement gecko leak checking for web-platform-tests, but do not
enable it yet due to oranges. Allows disabling leak checks for a
specific test using a 'leaks' key in test metadata. This causes the
browser to restart before running the (group of) tests with leak
checking disabled. The feature can be enabled by passing --leak-check
on the command line.

Review commit: https://reviewboard.mozilla.org/r/125436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125436/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8853344 [details]
Bug 1352357 - Add leak checking support for web-platform-tests,

https://reviewboard.mozilla.org/r/125436/#review128880

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8853344 [details]
Bug 1352357 - Add leak checking support for web-platform-tests,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125436/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d405c6bc179d
Add leak checking support for web-platform-tests, r=automatedtester

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d405c6bc179d

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This seems to have broken the Servo ./mach, at least when run within m-c:

1. Go to m-c checkout
2. cd servo


```
$ ./mach --help
Pip failed to execute properly:
Output:
Error:   Could not find a version that satisfies the requirement mozleak>=0.1 (from -r /Users/jryans/projects/mozilla/gecko-dev-stylo/servo/../testing/web-platform/harness/requirements_firefox.txt (line 6)) (from versions: )
No matching distribution found for mozleak>=0.1 (from -r /Users/jryans/projects/mozilla/gecko-dev-stylo/servo/../testing/web-platform/harness/requirements_firefox.txt (line 6))
```

Comment 7

[Bobby Holley (:bholley)]

Yes, this is a very troublesome hiccup for stylo. James, is this something you can fix easily?

Comment 8

[James Graham [:jgraham]]

Apparently we never released mozleak to pypi. I just did that; does that fix this issue?

Comment 9

[Bobby Holley (:bholley)]

(In reply to James Graham [:jgraham] from comment #8)
> Apparently we never released mozleak to pypi. I just did that; does that fix
> this issue?

Yep, works great - thanks!