Delete unused CSS after RectHighlighter was removed

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 55

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [bugday-20170426])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

In bug 1335691 we removed the RectHighlighter, but we forgot to also delete the CSS for it.

The CSS is here: http://searchfox.org/mozilla-central/rev/72fe012899a1b27d34838ab463ad1ae5b116d76b/devtools/server/actors/highlighters.css#261-267

So it's really not a lot, but we should still remove it.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8853357 [details]
Bug 1352369 - Delete unused RectHighlighter CSS;

https://reviewboard.mozilla.org/r/125476/#review128502

Looks good to me! Good catch!
Attachment #8853357 - Flags: review?(zer0) → review+

Comment 3

a year ago
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0eb9f9895e7
Delete unused RectHighlighter CSS; r=zer0

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e0eb9f9895e7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this on Firefox Nightly according to (2017-03-31)

Fixing bug is verified on Latest Nightly--Build ID : (20170430030208),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:55.0) Gecko/20100101 Firefox/55.0

Tested OS-- Windows7 32bit

[bugday-20170426]
Whiteboard: [bugday-20170426]

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.