Closed Bug 1352381 Opened 3 years ago Closed 2 years ago
Agent Overrides .js and User Agent Overrides .manifest for Thunderbird
See bug 1351980. The change needed on the Thunderbird side is adding a couple of lines like this <https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7c92033bb1bd1317d12d79e6d6e4d0473133ad#l3.12> to the package manifest.
Ehsan, thank you for the heads up. r? to all sub tree reviewers. If m-c merges before we have have all r+, Jörg can land it with r=bustage-fix.
The patch looks correct to me. :-) Thanks for the super fast turn around.
Comment on attachment 8853375 [details] [diff] [review] Bug1352381.patch I think I can handle this super-hard review ;-) Thanks to Ehsan for notifying us and thanks to Richard as always!
Thanks for taking care of suite.
Thanks! I'm quite fine in the future just letting one of use handle review like this.
Sorry, I ended up landing a totally different (and hacky) fix for bug 1351980. :/ You need to do something like the nsBrowserGlue.js hunks here <https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5e8370f845e5bfe8f5d14a69ad3c848cedfe45#l2.1> for all of the Gecko based applications in comm-central. Please note that UserAgentOverrides.init() needs to be called after profile-after-changed has been dispatched but before Gecko makes any HTTP requests. I'd be happy to help answer any questions, please needinfo me. Sorry for the change of plans. I couldn't get the proper fix to work.
looking at mailGlue.js and nsSuiteGlue.js and if after profile-after-change it should probably end up in > case "final-ui-startup": > this._onProfileStartup(); But its used much earlier in the _init of nsBrowserGlue.js. Would it be safe here for the comm-central programs too?
Just seeing that nsSuiteGlue already had this for a long time so it probably needs only to be done for TB.
You're referring to https://dxr.mozilla.org/comm-central/rev/b08dc613a3d275711f76b42cf0ceba1119d82f02/suite/common/src/nsSuiteGlue.js#17 https://dxr.mozilla.org/comm-central/rev/b08dc613a3d275711f76b42cf0ceba1119d82f02/suite/common/src/nsSuiteGlue.js#371 https://dxr.mozilla.org/comm-central/rev/b08dc613a3d275711f76b42cf0ceba1119d82f02/suite/common/src/nsSuiteGlue.js#505 https://dxr.mozilla.org/comm-central/rev/b08dc613a3d275711f76b42cf0ceba1119d82f02/suite/common/src/nsSuiteGlue.js#580 So you suggest to add something to mail/components/mailGlue.js Since bug 1351980 has landed, will TB be busted without it?
Not sure if this is needed in Thunderbird but I would put the the getter, init and uninit in mailGlue.js. Would need to check out what the additional suite code does but probably an old and half forgotten enhancement.
Comment on attachment 8853375 [details] [diff] [review] Bug1352381.patch This patch is more needed.
Attachment #8853375 - Attachment is obsolete: true
Assignee: richard.marti → nobody
Status: ASSIGNED → NEW
Not setting review. Not tested yet and not sure if Thunderbrid needs it anyway.
I'm *so* sorry for my delay here. I have a super long queue these days and I didn't notice that this bug has stuck in there. My apologies. Looks like SeaMonkey is already taken care of. Attachment 8855044 [details] [diff] is needed for Thunderbird. (Note that the "bustage" without this is that the User-Agent overrides won't work with Thunderbird if it uses them, but if not it won't be noticeable, but it's good practice to make sure the code does the right thing in case in the future someone needs to use it for some specific need. Specially since this is a feature that is useful for cases where you want to roll out some kind of an emergency fix. :-)
Comment on attachment 8855044 [details] [diff] [review] 1352381-useragentoverrides-part2.patch OK, thanks Ehsan, let's have it ;-)
Attachment #8855044 - Flags: review+
2 years ago
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
2 years ago
Assignee: nobody → frgrahl
You need to log in before you can comment on or make changes to this bug.