Closed Bug 1352389 Opened 3 years ago Closed 3 years ago

Having nsAutoScriptBlocker in SetAttr and mozAutoDocUpdate in SetAttrAndNotify means most of the attribute sets end up creating script runners

Categories

(Core :: DOM: Core & HTML, enhancement)

50 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files)

...because of the stuff EndUpdate() does.
Attached patch patchSplinter Review
Commit message missing.
It could be:

-m "Bug 1352389, don't push extra script blocker on stack when setting attributes, r=bz"
Attachment #8853409 - Flags: review?(bzbarsky)
Comment on attachment 8853409 [details] [diff] [review]
patch

How about we also have a "mozAutoDocUpdate&" arg to SetAttrAndNotify, so that it's impossible to call without having one on the stack?

r=me with that.
Attachment #8853409 - Flags: review?(bzbarsky) → review+
That is what I had initially, but then realized I need the composed doc.
I think there are rare enough callers for SetAttrAndNotify so I'm not too worried.
But I can add the param I had back.
> That is what I had initially, but then realized I need the composed doc.

Yes, I meant pass both.
Attached patch +guard paramSplinter Review
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30fe7c61b5db
don't push extra script blocker on stack when setting attributes, r=bz
Backing out. Either this or another patch caused some issues.
Keywords: leave-open
Keywords: leave-open
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fde6f9f9ef00
don't push extra script blocker on stack when setting attributes, r=bz
https://hg.mozilla.org/mozilla-central/rev/fde6f9f9ef00
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.