1352400 - Inline tag br accepts margin styling

Status: RESOLVED DUPLICATE of bug 1621387

(Core :: Layout, defect, P3)

Description

[John P. Green]

Attachment: Reduced test case. Div 1 has no style applied to the content, Div 2 uses the "Lobotomized Owl" selector, Div 3 has the fix I had to implement

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36

Steps to reproduce:

Using the "Lobotomized Owl" selector on a content block with elements otherwise set to have no margin.


Actual results:

Firefox (and only Firefox) applied the selector to the inline br tag.


Expected results:

No margins should've been applied to the inline br tag.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: testcase 2 (more reduced, renders with ~500px between the two lines, only in Firefox)

Here's a testcase showing the issue a bit more clearly.

This isn't related to selector matching, but rather whether br elements do anything with margins that are explicitly applied to it. In Firefox, those margins do get honored. In other browsers, those margins seem to get ignored.

Comment 3

[Daniel Holbert [:dholbert]]

Marking as 'New' (i.e. confirmed) since there's a valid interop issue here (Firefox disagrees with Blink/WebKit). The interop situation in general around applying styles to br is a bit hazy, though (see e.g. bug 1547246 for other br styles having varying impact in Firefox vs. other browsers), and I'm not sure this behavior is well-specified.

Comment 4

[Daniel Holbert [:dholbert]]

Ah, it seems we have bug 1621387 filed on this too, which has a bit more discussion and a spec issue associated with it. So even though this one's older, it's maybe best to use that as the canonical spot for this bug at this point.