Closed Bug 1352440 Opened 8 years ago Closed 8 years ago

Cleanup old use of mocking requests.get and requests.post

Categories

(Socorro :: Webapp, task)

Product:
Socorro
Component:
Webapp
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: peterbe, Assigned: peterbe)

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/socorro/pull/3714
44 bytes, text/x-github-pull-request
Details | Review
In the olden days, we used to have the webapp get its data from the middleware by doing requests.get(...). We then folded that in. Slowly. One of the last one was the Bugs model. Our test code still contains a lot of legacy use of `@mock.patch('crashstats.crashstats.models.Bugs.get')` which is not only the wrong thing to mock but is no longer necessary.
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/4196874bea0965745f43793ebe38547840643349 fixes bug 1352440 - Cleanup old use of mocking (#3714) * fixes bug 1352440 - Cleanup old use of mocking requests.get and requests.post * correction from rebase
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: