Closed Bug 1352494 Opened 3 years ago Closed 3 years ago

Remove bundleclone from hg.mozilla.org

Categories

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(10 files)

59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
59 bytes, text/x-review-board-request
glob
: review+
Details
Mercurial 3.6 integrated the bundleclone feature as a core feature (clonebundles). Since bug 1216216, we've been supporting both the legacy bundleclone feature and the modern clonebundles.

I just looked at server logs and we're seeing maybe 20 requests per day for the bundleclone manifest. Contrast with 20,000+ per day for clonebundles.

I think it is time we remove bundleclone support from the server.
Comment on attachment 8853544 [details]
hgmo: delay import mozbuildinfo module;

https://reviewboard.mozilla.org/r/125596/#review128532
Attachment #8853544 - Flags: review?(glob) → review+
Comment on attachment 8853545 [details]
ansible/hg-ssh: stop generate legacy stream bundles (bug 1352494);

https://reviewboard.mozilla.org/r/125598/#review128552
Attachment #8853545 - Flags: review?(glob) → review+
Comment on attachment 8853546 [details]
generate-hg-s3-bundles: stop supporting legacy stream bundles (bug 1352494);

https://reviewboard.mozilla.org/r/125600/#review128554
Attachment #8853546 - Flags: review?(glob) → review+
Comment on attachment 8853547 [details]
generate-hg-s3-bundles: stop generating bundleclone manifests (bug 1352494);

https://reviewboard.mozilla.org/r/125602/#review128572

::: hgserver/tests/test-clonebundles.t
(Diff revision 1)
>    adding changesets
>    adding manifests
>    adding file changes
>    added 1 changesets with 1 changes to 1 files
>  
> -#else

can probably drop the #if hg36+ checks too
Attachment #8853547 - Flags: review?(glob) → review+
Comment on attachment 8853547 [details]
generate-hg-s3-bundles: stop generating bundleclone manifests (bug 1352494);

https://reviewboard.mozilla.org/r/125602/#review128572

> can probably drop the #if hg36+ checks too

Yeah, I was thinking about doing that globally in the "upgrade to 4.1" series. I didn't want to scope bloat this series any more.
Comment on attachment 8853548 [details]
hgmo: stop supporting bundleclone for IP address filtering (bug 1352494);

https://reviewboard.mozilla.org/r/125604/#review128610
Attachment #8853548 - Flags: review?(glob) → review+
Comment on attachment 8853549 [details]
hgmo: support fetching clonebundles.manifest during pull (bug 1352494);

https://reviewboard.mozilla.org/r/125606/#review128612
Attachment #8853549 - Flags: review?(glob) → review+
Comment on attachment 8853550 [details]
ansible/hg-web: stop loading bundleclone extension (bug 1352494);

https://reviewboard.mozilla.org/r/125608/#review128614
Attachment #8853550 - Flags: review?(glob) → review+
Comment on attachment 8853551 [details]
generate-hg-s3-bundles: use core command for producing stream clone bundles (bug 1352494);

https://reviewboard.mozilla.org/r/125610/#review128618
Attachment #8853551 - Flags: review?(glob) → review+
Comment on attachment 8853552 [details]
ansible/hg-ssh: stop loading bundleclone extension (bug 1352494);

https://reviewboard.mozilla.org/r/125612/#review128934
Attachment #8853552 - Flags: review?(glob) → review+
Comment on attachment 8853553 [details]
bundleclone: remove extension (bug 1352494);

https://reviewboard.mozilla.org/r/125614/#review128940
Attachment #8853553 - Flags: review?(glob) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/fc5f2907f112
ansible/hg-ssh: stop generate legacy stream bundles ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7e5d34570bdd
generate-hg-s3-bundles: stop supporting legacy stream bundles ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/57947e522a92
generate-hg-s3-bundles: stop generating bundleclone manifests ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ccdd561cf624
hgmo: stop supporting bundleclone for IP address filtering ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ceb9b26fb5ee
hgmo: support fetching clonebundles.manifest during pull ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/0ffb4d71b9d0
ansible/hg-web: stop loading bundleclone extension ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/07543fc9ebbc
generate-hg-s3-bundles: use core command for producing stream clone bundles ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c71c0cfdd31e
ansible/hg-ssh: stop loading bundleclone extension ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/c805a3fc11ca
bundleclone: remove extension ; r=glob
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 34ab846f4c6a -d b895763b7fe7: rebasing 5213:34ab846f4c6a "hgmo: delay import mozbuildinfo module; r=glob"
merging hgext/hgmo/__init__.py
note: rebase of 5213:34ab846f4c6a created no changes to commit
rebasing 5214:a49dd1921980 "ansible/hg-ssh: stop generate legacy stream bundles (bug 1352494); r=glob"
note: rebase of 5214:a49dd1921980 created no changes to commit
rebasing 5215:81d8578a372c "generate-hg-s3-bundles: stop supporting legacy stream bundles (bug 1352494); r=glob"
merging hgserver/tests/test-clonebundles.t
merging scripts/generate-hg-s3-bundles
warning: conflicts while merging scripts/generate-hg-s3-bundles! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
You need to log in before you can comment on or make changes to this bug.