1352505 - Removing search engines from preferences disabled 'Restore defaults' button

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #1327953 +++

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open about:preferences#search in a clear profile
2. Select the last search engine
3. Click button "Remove" 3 times to delete selected search engine

AR:  Button "Restore Default Search Engines" is disabled
ER:  The button should be enabled, because 3 default search engines were deleted.

This is a regression from bug 1335907, as it got lost in the merge.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1352505 - Fix enabling the 'Restore Default Search Engines' button when removing a default engine.

Re-apply the patch from bug 1327953 since it got lost in the re-arrangement of preference code in bug 1335907.

Review commit: https://reviewboard.mozilla.org/r/125566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125566/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8853488 [details]
Bug 1352505 - Fix enabling the 'Restore Default Search Engines' button when removing a default engine.

https://reviewboard.mozilla.org/r/125566/#review128192

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71685d39b2a1
Fix enabling the 'Restore Default Search Engines' button when removing a default engine. r=Gijs

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/71685d39b2a1

Comment 5

[Saheda Reza [:Antora]]

I have successfully reproduced this bug on firefox nightly according to(2017-03-31)

Fixing bug is verified on Latest Nightly-- Build ID: (20170402030202),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0

Tested OS -- Windows10 32bit

[bugday-20170329]

Comment 6

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 x64, Ubuntu 14.04 x64 and Mac OS X 10.11 using latest Nightly 55.0a1 (2017-04-03).