1352624 - Littlefox theme cant add button to toolbar, default theme can

Status: RESOLVED INVALID

(WebExtensions :: General, defect)

Description

[elfgoh]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170330120906

Steps to reproduce:

Click on the menu button
Click customise
Drag pocket button to desired position on toolbar

Detailed at "Move the Pocket button to your toolbar or menu"
https://support.mozilla.org/t5/Sync-and-Save/Where-is-the-quot-Pocket-for-Firefox-quot-button/ta-p/30108

Also applies to other buttons


Actual results:

Toolbar remains unchanged


Expected results:

Toolbar should be updated with new buttons

Comment 1

[YF (Yang)]

Works for me with https://addons.mozilla.org/en-US/firefox/addon/littlefox-for-firefox/ in 53.0b7 on Win10.

Comment 2

[Loic]

WFM too with 53b8 on Win 7. Could you test with a fresh profile and only this theme installed?
https://support.mozilla.org/t5/Install-and-Update/Use-the-Profile-Manager-to-create-and-remove-Firefox-profiles/ta-p/2914

Comment 3

[elfgoh]

Attachment: New profile with littleFox installed and activated. Default pocket button in toolbar disappears and unable to edit toobar

Comment 4

[elfgoh]

Attachment: New profile default theme enabled. Pocket button in toolbar is present

Comment 5

[elfgoh]

Above screenshots are captured in 53.0b8

Comment 6

[Loic]

It could be an issue only specific to Mac OSX and related to customization

Gijs, are you able to move the Pocket icon in custom mode with this theme installed in FF53 on OSX?

Comment 7

[:Gijs (he/him)]

(In reply to Loic from comment #6)
> It could be an issue only specific to Mac OSX and related to customization
> 
> Gijs, are you able to move the Pocket icon in custom mode with this theme
> installed in FF53 on OSX?

No. Seems like an issue with the theme, tbh. Customize mode is completely broken, you can barely get into it (but e.g. the toolbox area doesn't show up) and you can then no longer exit it. There are errors in the browser console on startup. AFAICT this is because the theme's global.css file uses a Linux-based rule for toolbar XBL bindings for all toolbars (including the navigation toolbar), and this produces unexpected results. In this sense, themes run XBL and thereby code, rather than just styling, and this is why stuff breaks. There isn't very much we can do about this from within Firefox, and so I'm moving this to Tech Evangelism and CC'ing the author of the theme.

Comment 8

[elfgoh]

In case it is a useful data point, switching over to the default theme and adding the pocket button to the toolbar works. But when switching back to littlefox theme, the button disappears. THe results are similar even if littlefox is uninstalled and reinstalled

Comment 9

[Loic]

elfgoh, did you contact the add-on authors? They can fix it easily on their side, I guess.

Comment 10

[elfgoh]

Oh I have not. I had thought that the author may be already on this since he has been cc-ed. But I will drop him an email just to be sure

Comment 11

[:Gijs (he/him)]

We've stopped support for legacy themes, so this can be closed now. WebExtension add-ons can now do various things in one add-on, I believe, and won't break customization.