[meta] Add a URL-bar based page action menu

NEW
Unassigned

Status

()

enhancement
P5
normal
2 years ago
Last year

People

(Reporter: Gijs, Unassigned)

Tracking

(Depends on 8 bugs, Blocks 1 bug, {meta})

53 Branch
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [photon-structure])

Attachments

(1 attachment)

Reporter

Description

2 years ago
This will need:

- an anchor
- a new panel that uses panelmultiview
- implementations for the existing functionality:
-- copy link
-- email link
-- save to pocket
-- send to device (with subview of devices - should probably hide this if not signed into sync, and maybe not create a subview if there is only 1 other device to send it to)
-- screenshot (dependent on integrating page shot)

- implementation of new functionality (share subview powered by OS-specific implementation). This will definitely need a more detailed spec.
Whiteboard: [photon]
Flags: qe-verify-
Reporter

Updated

2 years ago
Depends on: 1353360
So, in this new world, page action views will work similarly to how hamburger panel subviews currently work, implementation-wise?

If so, that would simplify the different implementations that we have for browser action and page action views in WebExtensions. But if we have similar sizing constraints, that might cause problems for extensions that expect more freedom in what they can do with page action panels...
Reporter

Comment 2

2 years ago
(In reply to Kris Maglione [:kmag] from comment #1)
> So, in this new world, page action views will work similarly to how
> hamburger panel subviews currently work, implementation-wise?

At the moment, I'm not planning for this to affect webextension page actions for v1 unless we magically end up with spare time to work on that. In part because it's not simple because of what you said next:

> But if we have similar sizing constraints,

Yes, the panel has a fixed width.

> that might cause problems for extensions that
> expect more freedom in what they can do with page action panels...

Indeed.

Updated

2 years ago
Depends on: 1355322

Updated

2 years ago
Depends on: 1355323
Whiteboard: [photon] → [photon-structure]

Updated

2 years ago
Depends on: 1360054

Updated

2 years ago
Depends on: 1360055
Reporter

Comment 3

2 years ago
There's an updated mock which adds a bit more complexity here - https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/230998673_Action_Menu .

We'll need to add some more deps for this. Ni me to add some.
Flags: needinfo?(gijskruitbosch+bugs)
Reporter

Comment 4

2 years ago
(In reply to :Gijs (gone until May 2, prefer other reviewers) from comment #3)
> There's an updated mock which adds a bit more complexity here -
> https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/
> 230998673_Action_Menu .
> 
> We'll need to add some more deps for this. Ni me to add some.

That is, if nobody beats me to it, because I didn't get round to it today - don't let me stop you.
Depends on: 1363168
Depends on: 1363169
Reporter

Updated

2 years ago
Depends on: 1363180
Reporter

Updated

2 years ago
Depends on: 1363182
Reporter

Updated

2 years ago
Depends on: 1363183
Reporter

Updated

2 years ago
Depends on: 1363188
Reporter

Updated

2 years ago
Flags: needinfo?(gijskruitbosch+bugs)

Comment 5

2 years ago
Maybe an option to re-add the refresh back in the address bar? Or is that a different bug
^ What he said.  I like to click my refresh button.
Actually, I found the other refresh button in Customize (outside of the url bar) but I prefer it inside.  Also, I was messing around with Classic Theme Restorer for the Star bookmark button, which I actually got used to outside of the url bar, and now I've kind of broken it.  (And, tbh, I still don't even understand what Pocket is..)
Is there any way I can separate the star from the bookmark list button?
This change seems to have messed a lot with how I had Classic Theme Restorer set up, in a bunch of different ways.

Updated

2 years ago
Depends on: 1366041
Priority: -- → P5

Updated

2 years ago
Depends on: 1367927

Updated

2 years ago
Depends on: 1374477
Reporter

Updated

2 years ago
Depends on: 1375687
Reporter

Updated

2 years ago
Depends on: 1377227
Reporter

Updated

2 years ago
Depends on: 1377535
Reporter

Updated

2 years ago
Depends on: 1366327
Reporter

Updated

2 years ago
Depends on: 1378560
Reporter

Updated

2 years ago
Depends on: 1387042
Depends on: 1387422
Reporter

Updated

2 years ago
No longer depends on: 1387422

Updated

2 years ago
Depends on: 1388163

Updated

2 years ago
Depends on: 1388528
Reporter

Updated

2 years ago
No longer depends on: 1388495
Reporter

Updated

2 years ago
Depends on: 1388376
Reporter

Updated

2 years ago
No longer depends on: 1388163
Reporter

Updated

2 years ago
Depends on: 1388589

Updated

2 years ago
Depends on: 1388835

Updated

2 years ago
Depends on: 1391759

Updated

2 years ago
Depends on: 1392733

Updated

2 years ago
Depends on: 1395387
Reporter

Updated

2 years ago
Depends on: 1395622
Reporter

Updated

2 years ago
No longer depends on: 1395622

Updated

2 years ago
Depends on: 1401835
Reporter

Updated

2 years ago
Depends on: 1387777

Updated

2 years ago
Depends on: 1417272

Updated

2 years ago
Depends on: 1417273
You need to log in before you can comment on or make changes to this bug.