1387777, 1388376, 1377227, 1377535, 1387042, 1388528, 1388589, 1388835, 1391759, 1392733, 1395178, 1402721
This will need: - an anchor - a new panel that uses panelmultiview - implementations for the existing functionality: -- copy link -- email link -- save to pocket -- send to device (with subview of devices - should probably hide this if not signed into sync, and maybe not create a subview if there is only 1 other device to send it to) -- screenshot (dependent on integrating page shot) - implementation of new functionality (share subview powered by OS-specific implementation). This will definitely need a more detailed spec.
So, in this new world, page action views will work similarly to how hamburger panel subviews currently work, implementation-wise? If so, that would simplify the different implementations that we have for browser action and page action views in WebExtensions. But if we have similar sizing constraints, that might cause problems for extensions that expect more freedom in what they can do with page action panels...
(In reply to Kris Maglione [:kmag] from comment #1) > So, in this new world, page action views will work similarly to how > hamburger panel subviews currently work, implementation-wise? At the moment, I'm not planning for this to affect webextension page actions for v1 unless we magically end up with spare time to work on that. In part because it's not simple because of what you said next: > But if we have similar sizing constraints, Yes, the panel has a fixed width. > that might cause problems for extensions that > expect more freedom in what they can do with page action panels... Indeed.
There's an updated mock which adds a bit more complexity here - https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/230998673_Action_Menu . We'll need to add some more deps for this. Ni me to add some.
(In reply to :Gijs (gone until May 2, prefer other reviewers) from comment #3) > There's an updated mock which adds a bit more complexity here - > https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/ > 230998673_Action_Menu . > > We'll need to add some more deps for this. Ni me to add some. That is, if nobody beats me to it, because I didn't get round to it today - don't let me stop you.
Maybe an option to re-add the refresh back in the address bar? Or is that a different bug
^ What he said. I like to click my refresh button.
Actually, I found the other refresh button in Customize (outside of the url bar) but I prefer it inside. Also, I was messing around with Classic Theme Restorer for the Star bookmark button, which I actually got used to outside of the url bar, and now I've kind of broken it. (And, tbh, I still don't even understand what Pocket is..)
Is there any way I can separate the star from the bookmark list button?
This change seems to have messed a lot with how I had Classic Theme Restorer set up, in a bunch of different ways.
Depends on: 1388495
Depends on: 1389727
Depends on: 1402721
Depends on: 1403891
Depends on: 1419043
Depends on: 1419044
You need to log in before you can comment on or make changes to this bug.