Container Tabs 'Learn More' link should be on the same line as the 'Enable Container Tabs' checkbox

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Preferences
--
major
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: gcp, Assigned: jaws)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
Today's Nightly had a severe regression in Preferences. It's very hard to find settings right now, and some settings appear in panes with a description that doesn't have anything to do with them.

1) Search settings are very important, yet lumped into the middle of "General", aside a small part, that has got nothing to do with Privacy And Security, yet is in the middle of that pane (Location Bar), and has to link back to the middle of General (which is an indication we don't actually expect people to manage to find the other settings by themselves...)

2) "Reports" is in "Updates" yet obviously has nothing whatsoever to do with it.

3) Proxy (Connection) settings probably doesn't belong in "Privacy And Security", mainly because it's a setting some people will need to get on the internet at all.

4) "Cached Web Content" is in "Privacy and Security". The link here is weird at best.

5) "Site Data" appears to be entirely broken. Buttons display awkwardly on the right, clicking "Settings" has no effect.

6) Some display aspects are totally inconsistent. Look at DRM Content vs Container Tabs, and note the positioning of "Learn More".

In general lumping everything together in a few huge categories also means that one has to do a lot of scrolling to find anything now, rather than clicking categories and seeing everything at a glance.

I think we at least need a "Search" pane, probably a "Display and Language pane", and something like a "Stored Data" pane. Probably other sane orderings are possible, but anything is better than just lumping everything together.

Comment 1

8 months ago
This is probably the result of Bug 1335907.
See Also: → bug 1355753
(In reply to Gian-Carlo Pascutto [:gcp] from comment #0)
> Today's Nightly had a severe regression in Preferences. It's very hard to
> find settings right now, and some settings appear in panes with a
> description that doesn't have anything to do with them.
> 
> 1) Search settings are very important, yet lumped into the middle of
> "General", aside a small part, that has got nothing to do with Privacy And
> Security, yet is in the middle of that pane (Location Bar), and has to link
> back to the middle of General (which is an indication we don't actually
> expect people to manage to find the other settings by themselves...)

The link from Location Bar to Search is not a regression from the old organization. The Location Bar settings are privacy-related, the search engine less so (though it could be considered that as a stretch). Otherwise, searching is a pretty integral part of using the web browser even when privacy & security is not a concern.

> 2) "Reports" is in "Updates" yet obviously has nothing whatsoever to do with
> it.

This is filed as bug 1355522.

> 3) Proxy (Connection) settings probably doesn't belong in "Privacy And
> Security", mainly because it's a setting some people will need to get on the
> internet at all.

The previous location for this was Advanced > Network. The "Advanced" section quickly became a dumping ground for any preferences that people couldn't figure out where to put otherwise. Barring a "network" specific category, there are obvious associations between proxies and privacy.

> 4) "Cached Web Content" is in "Privacy and Security". The link here is weird
> at best.

For privacy reasons it may be useful to know what data is cached on your machine and how to remove traces of it.

> 5) "Site Data" appears to be entirely broken. Buttons display awkwardly on
> the right, clicking "Settings" has no effect.

Site Data is still a work-in-progress. See bug 1312351.

> 6) Some display aspects are totally inconsistent. Look at DRM Content vs
> Container Tabs, and note the positioning of "Learn More".

Container Tabs is still a Nightly-only feature and is still a work-in-progress. The "Learn More" link should be moved to the same line as the checkbox like with DRM Content. Thank you for calling attention to this.

> In general lumping everything together in a few huge categories also means
> that one has to do a lot of scrolling to find anything now, rather than
> clicking categories and seeing everything at a glance.
> 
> I think we at least need a "Search" pane, probably a "Display and Language
> pane", and something like a "Stored Data" pane. Probably other sane
> orderings are possible, but anything is better than just lumping everything
> together.

The categories were determined through various rounds of user research and provided a much quicker time-to-completion score versus the older organization and a few other attempts at other organizations. A 'search' feature is being worked on now that will allow for searching for preferences across categories. See bug 1335905 and its follow-ups.

The only issue pointed out in comment #0 that doesn't have a bug on file for yet is the issue related to Container Tabs. I'm changing the summary now to focus on the Container Tabs bug.
Summary: Lack of preference categories and misplaced items makes it very hard to find settings → Container Tabs 'Learn More' link should be on the same line as the 'Enable Container Tabs' checkbox
(Assignee)

Updated

8 months ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8857487 [details]
Bug 1352738 - Move the position of the Container Tabs 'Learn More' link so it is inline with the checkbox like the other preferences.

https://reviewboard.mozilla.org/r/129460/#review132018

LGTM
Attachment #8857487 - Flags: review?(jkt) → review+

Comment 5

8 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/001dd9c34e20
Move the position of the Container Tabs 'Learn More' link so it is inline with the checkbox like the other preferences. r=jkt

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/001dd9c34e20
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 7

6 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-04-01) on Windows 8.1 (64 bit).

This bug's fix is verified on Latest Nightly 55.0a1.

Build ID : 20170531030204
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]

Comment 8

6 months ago
The issue is no longer reproducible on Firefox 55.0a1 (build ID:Build ID: 20170608030205).
[bugday-20170607]
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.