1352781 - stylo: Parse 'first baseline' and 'last baseline' for <baseline-position>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Hiroyuki Ikezoe (:hiro)]

We should parse 'first baseline' and 'last baseline' in parse_auto_normal_stretch_baseline, parse_normal_stretch_baseline and parse_normal_or_baseline.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f93067112ad86f25a08860254e4161ea3c12e486

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1352781 - Parse "first baseline" and "last baseline".

Review commit: https://reviewboard.mozilla.org/r/125852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125852/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1352781 - Serialize baseline values correctly.

Review commit: https://reviewboard.mozilla.org/r/125854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125854/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1352781 - Update reftest expectations.

Review commit: https://reviewboard.mozilla.org/r/125856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125856/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1352781 - Update mochitest expectations.

Review commit: https://reviewboard.mozilla.org/r/125858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125858/

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8853819 [details]
Bug 1352781 - Parse "first baseline" and "last baseline".

https://reviewboard.mozilla.org/r/125852/#review128786

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8853820 [details]
Bug 1352781 - Serialize baseline values correctly.

https://reviewboard.mozilla.org/r/125854/#review128788

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8853821 [details]
Bug 1352781 - Update reftest expectations.

https://reviewboard.mozilla.org/r/125856/#review128790

Comment 8

[Manish Goregaokar [:manishearth]]

Comment on attachment 8853822 [details]
Bug 1352781 - Update mochitest expectations.

https://reviewboard.mozilla.org/r/125858/#review128792

Comment 9

[Hiroyuki Ikezoe (:hiro)]

https://github.com/servo/servo/pull/16253

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8853821 [details]
Bug 1352781 - Update reftest expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125856/diff/1-2/

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8853822 [details]
Bug 1352781 - Update mochitest expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125858/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9f0dbd4cdfc
Update reftest expectations. r=manishearth
https://hg.mozilla.org/integration/autoland/rev/1c0b13ba59ce
Update mochitest expectations. r=manishearth

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f9f0dbd4cdfc
https://hg.mozilla.org/mozilla-central/rev/1c0b13ba59ce