Closed Bug 1352802 Opened 3 years ago Closed 3 years ago

Typo fixes around 'accessible'

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: paul.bignier, Assigned: paul.bignier)

Details

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

Found typos around the term "accessible"
Comment on attachment 8853738 [details] [diff] [review]
0001-Typo-fixes-around-accessible.patch

Aryx from #introduction suggested MattN as reviewer
Attachment #8853738 - Flags: review?(MattN+bmo)
Attachment #8853738 - Attachment is patch: true
Attachment #8853738 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8853738 [details] [diff] [review]
0001-Typo-fixes-around-accessible.patch

Review of attachment 8853738 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/nss/fuzz/certDN_target.cc
@@ +21,5 @@
>      TEST_FUNCTION(CERT_NameToAscii)
>      TEST_FUNCTION(CERT_GetCertEmailAddress)
>  
>      // These functions call CERT_GetNameElement with different OIDs.
> +    // Unfotunately CERT_GetNameElement is not accessible from here.

Hi, can also fix that "Unfotunately", please?
Thanks! Btw I checked those fixes against
https://dxr.mozilla.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt?force=
so no thirdparty code is modified.
Attachment #8853738 - Attachment is obsolete: true
Attachment #8853738 - Flags: review?(MattN+bmo)
Attachment #8853741 - Flags: review?(MattN+bmo)
Comment on attachment 8853741 [details] [diff] [review]
0001-Typo-fixes-around-accessible.patch

Review of attachment 8853741 [details] [diff] [review]:
-----------------------------------------------------------------

For your other patches where I said they were in a third-party library, can you update tools/rewriting/ThirdPartyPaths.txt in those patches where you're reverting the changes to said files. ThirdPartyPaths.txt is fairly new and not exhaustive.

Update the commit message format here too and request review again.

Thanks.

Btw. if you're looking for good first bugs you can take a look at https://www.joshmatthews.net/bugsahoy/?simple=1

::: python/altgraph/altgraph/Dot.py
@@ -8,5 @@
>  (the **dot** file generation) while transparently exposing most of its features.
>  
>  To display the graphs or to generate image files the `graphviz <http://www.research.att.com/sw/tools/graphviz/>`_
>  package needs to be installed on the system, moreover the :command:`dot` and :command:`dotty` programs must
> -be accesible in the program path so that they can be ran from processes spawned

This is a third-party python package, please revert.

::: python/altgraph/doc/_build/html/_sources/dot.txt
@@ +12,5 @@
>  .. _`graphviz`: <http://www.research.att.com/sw/tools/graphviz/>`_
>  
>  To display the graphs or to generate image files the `graphviz`_
>  package needs to be installed on the system, moreover the :command:`dot` and :command:`dotty` programs must
> +be accessible in the program path so that they can be ran from processes spawned

Same here

::: python/altgraph/doc/dot.rst
@@ +12,5 @@
>  .. _`graphviz`: <http://www.research.att.com/sw/tools/graphviz/>`_
>  
>  To display the graphs or to generate image files the `graphviz`_
>  package needs to be installed on the system, moreover the :command:`dot` and :command:`dotty` programs must
> +be accessible in the program path so that they can be ran from processes spawned

Same here

::: security/nss/fuzz/certDN_target.cc
@@ +21,5 @@
>      TEST_FUNCTION(CERT_NameToAscii)
>      TEST_FUNCTION(CERT_GetCertEmailAddress)
>  
>      // These functions call CERT_GetNameElement with different OIDs.
> +    // Unfortunately CERT_GetNameElement is not accessible from here.

I'm not sure if NSS still has its own processes and repo so I don't feel confident reviewing this file.
Attachment #8853741 - Flags: review?(MattN+bmo) → feedback+
Assignee: nobody → paul.bignier
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pure bad luck made me look at this bug at the very last so I didn't see your comment about ThirdPartyPaths.txt in time to update my other patches ><

Sorry about that. However, it's actually safer that I update the file in a separate patch. Noticing the file only lists folders, I may not list single files but whole folders (provided it makes sense to).

Thanks again,
Best regards,
Paul
Attachment #8853741 - Attachment is obsolete: true
Attachment #8854062 - Flags: review?(MattN+bmo)
Comment on attachment 8854062 [details] [diff] [review]
Typo fixes around accessible

Review of attachment 8854062 [details] [diff] [review]:
-----------------------------------------------------------------

In the future please use the following command to generate a patch from Git so it doesn't include the "[PATCH]" prefix: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#I%27m_all_used_to_Git_but_how_can_I_provide_Mercurial-ready_patches

I will check this in and make the fix myself.

Thanks.
Attachment #8854062 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/ccc7dd000cc2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Moving from Core::Untriaged to Core::General https://bugzilla.mozilla.org/show_bug.cgi?id=1407598
Component: Untriaged → General
You need to log in before you can comment on or make changes to this bug.