1352825 - Typo fixes around 'docshell'

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Paul Bignier]

Attachment: 0001-Typo-fixes-around-docshell.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

Found typos around the term "docshell"

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 8853758 [details] [diff] [review]
0001-Typo-fixes-around-docshell.patch

Review of attachment 8853758 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the commit message like so and then you can attach a new patch carrying over the r+ and add the checkin-needed keyword:

Bug 1352825 - Fix comment typos of 'docshell'. r=MattN

Comment 2

[Paul Bignier]

Attachment: 0001-Bug-1352825-Fix-comment-typos-of-docshell-.-r-MattN.patch

Comment 3

[Paul Bignier]

Did I miss something, it doesn't seem to have worked as expected?
Thanks for the pointer anyway.
Regards,
Paul

Comment 4

[Matthew N. [:MattN]]

You need to set the review flag to "+" still and add the "checkin-needed" keyword. The r? only automatically does things on mozreview which you're not using.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e88ab4d4bd
Fix comment typos of 'docshell'. r=MattN

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a7e88ab4d4bd