Closed
Bug 1352825
Opened 7 years ago
Closed 7 years ago
Typo fixes around 'docshell'
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: paul.bignier, Assigned: paul.bignier)
Details
Attachments
(1 file, 1 obsolete file)
|
6.93 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170323105023 Steps to reproduce: Found typos around the term "docshell"
|
Assignee | |
Updated•7 years ago
|
Attachment #8853758 -
Attachment is patch: true
Attachment #8853758 -
Attachment mime type: text/x-patch → text/plain
Attachment #8853758 -
Flags: review?(MattN+bmo)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8853758 [details] [diff] [review] 0001-Typo-fixes-around-docshell.patch Review of attachment 8853758 [details] [diff] [review]: ----------------------------------------------------------------- Please update the commit message like so and then you can attach a new patch carrying over the r+ and add the checkin-needed keyword: Bug 1352825 - Fix comment typos of 'docshell'. r=MattN
Attachment #8853758 -
Flags: review?(MattN+bmo) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8853758 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•7 years ago
|
||
Did I miss something, it doesn't seem to have worked as expected? Thanks for the pointer anyway. Regards, Paul
|
|
||
Comment 4•7 years ago
|
||
You need to set the review flag to "+" still and add the "checkin-needed" keyword. The r? only automatically does things on mozreview which you're not using.
Assignee: nobody → paul.bignier
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
|
|
||
Updated•7 years ago
|
Attachment #8854047 -
Flags: review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7e88ab4d4bd Fix comment typos of 'docshell'. r=MattN
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a7e88ab4d4bd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•