1352848 - Typo fixes around 'settings'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Paul Bignier]

Attachment: 0001-Typo-fixes-around-settings.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170323105023

Steps to reproduce:

Found typos around the term "settings"

Comment 1

[Matthew N. [:MattN]]

Comment on attachment 8853773 [details] [diff] [review]
0001-Typo-fixes-around-settings.patch

Review of attachment 8853773 [details] [diff] [review]:
-----------------------------------------------------------------

Same comments about the commit message apply to this bug too.

::: python/mock-1.0.0/docs/patch.txt
@@ -625,5 @@
>  patch and restore descriptors: class methods, static methods and properties.
>  You should patch these on the *class* rather than an instance.
>  
>  Since version 0.7.0 patch_ and patch.object_ work correctly with some objects
> -that proxy attribute access, like the `django setttings object

According to bug 803654, this an imported file and so it should be changed upstream first, not in mozilla-central.

::: python/mock-1.0.0/html/_sources/patch.txt
@@ +625,5 @@
>  patch and restore descriptors: class methods, static methods and properties.
>  You should patch these on the *class* rather than an instance.
>  
>  Since version 0.7.0 patch_ and patch.object_ work correctly with some objects
> +that proxy attribute access, like the `django settings object

Same here.

Comment 2

[Matthew N. [:MattN]]

Moving to Graphics since the only remaining fixable issue is there.

Comment 3

[Paul Bignier]

Attachment: Typo fixed in comment

Manually requesting review as it appears not to have worked on other patches :S

Regarding the python/ files, my only reference is the tools/rewriting/ThirdPartyPaths.txt list, thanks for pointing out that it is not enough, I will be careful in the future.

Regards,
Paul

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa9afbb50505
Fix spelling of 'settings' in comment. r=MattN

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aa9afbb50505