1352862 - Give back or replace the "i" keyboard shortcut to display in-progress jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Phil Ringnalda (:philor)]

Autoclassify stole the "i" keyboard shortcut away from toggling display of in-progress jobs. It needs to either give it back, replace it, or if it did already replace it, document what it replaced it with, since the help page currently lies and says that i does both in-progress and ignore the failure.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Excitingly[1], 'i' is technically defined as doing both things. Dunno if double-assigning means only the second one works, or if autoclassify is canceling out the intermittent toggle.

1. https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/main.js

Comment 2

[Phil Ringnalda (:philor)]

Now seems like a good time to give it back to me, since nobody is using autoclassify.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3430

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6fc039e58b40b62dd09c45eafdb72258cab9ce91
Bug 1352862 - Restore the 'i' keyboard shortcut to toggle in-progress jobs (#3430)

* Alphabetize keyboard shortcuts to help avoid introducing conflicts
* Also make a few autoclassify shortcuts use ctrl to reduce confusion
* Enable multi-select on a mac in the autoclassify panel