Icons on tabbar not inverted with dark LW-theme on macOS

RESOLVED FIXED in 5.4.1

Status

Calendar
General
RESOLVED FIXED
11 months ago
9 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Lightning 4.7
5.4.1
All
Mac OS X

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
With dark LW-Theme the calendar and task icons in tabbar aren't white.
(Assignee)

Comment 1

11 months ago
Created attachment 8853780 [details] [diff] [review]
brighttextIconFix.patch

There was a silly typo. I also synchronized the selectors from Linux and Windows.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8853780 - Flags: review?(philipp)
Attachment #8853780 - Flags: review?(philipp) → review+
(Assignee)

Updated

11 months ago
Keywords: checkin-needed

Comment 2

11 months ago
Looks like this typo was introduced in Lightning 4.7 with Bug 1234061. Should it be ported back for the upcoming release?
Version: unspecified → Lightning 4.7
(Assignee)

Comment 3

11 months ago
Comment on attachment 8853780 [details] [diff] [review]
brighttextIconFix.patch

I had no time to check, thank you for finding the regression.
Attachment #8853780 - Flags: approval-calendar-esr?(philipp)
Attachment #8853780 - Flags: approval-calendar-beta?(philipp)
Attachment #8853780 - Flags: approval-calendar-aurora?(philipp)
Attachment #8853780 - Flags: approval-calendar-esr?(philipp)
Attachment #8853780 - Flags: approval-calendar-esr+
Attachment #8853780 - Flags: approval-calendar-beta?(philipp)
Attachment #8853780 - Flags: approval-calendar-beta+
Attachment #8853780 - Flags: approval-calendar-aurora?(philipp)
Attachment #8853780 - Flags: approval-calendar-aurora+

Comment 4

11 months ago
https://hg.mozilla.org/comm-central/rev/9d73fdc3f0c3270fe4a4fc960f889cd159f7b999
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 5.7

Comment 5

11 months ago
Aurora (TB 54, Calendar 5.6):
https://hg.mozilla.org/releases/comm-aurora/rev/209c56091fe0e6aaebbf21b62e026bb39fddd833
Target Milestone: 5.7 → 5.6

Comment 6

11 months ago
Beta (TB 53, Calendar 5.5):
https://hg.mozilla.org/releases/comm-beta/rev/9eb699df5b12dd14e6415ec8533b7a577cce24b1
Target Milestone: 5.6 → 5.5

Comment 7

10 months ago
TB 52 ESR, Calendar 5.4:
https://hg.mozilla.org/releases/comm-esr52/rev/f3fa3d38b0a8bee7c6a15db5c1266d074c1a94d6
Target Milestone: 5.5 → 5.4
Keywords: checkin-needed

Updated

9 months ago
Target Milestone: 5.4 → 5.4.1
You need to log in before you can comment on or make changes to this bug.