Open Bug 1352886 Opened 8 years ago Updated 3 years ago

layout/ipc/Vsync{Child,Parent}.cpp are built as SOURCES instead of UNIFIED_SOURCES

Categories

(Core :: Web Painting, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox55 --- affected

People

(Reporter: dbaron, Unassigned)

Details

The files layout/ipc/VsyncChild.cpp and layout/ipc/VsyncParent.cpp are built by being defined as SOURCES instead of UNIFIED_SOURCES in the moz.build file. This was added in https://hg.mozilla.org/mozilla-central/rev/b9cd3847b0af for bug 1121331. Exceptionally, there is no comment explaining why these files need to be built non-unified. There should either be a comment explaining why, or they should be in UNIFIED_SOURCES instead of SOURCES.
Flags: needinfo?(hshih)
There were some unified-build problems before, but we could try the unified-build now.
Flags: needinfo?(hshih)
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.