1352959 - [Regression] Activity stream - top sites issues

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Isabel Rios[:isabel_rios]]

Attachment: topsites1.png

Master build 58ededc6e2a534df3b2d77883319346774fb1da3

XCUITests covering AS are failing:
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/58e04d19c4ac6f0001d4a25f#tests

It is also possible to reproduce manually on simulator (iphone 6 10.2) and ipod touch (10.2) these issues:

- More than 6 top sites are shown, so the control page button does not appear when it should. Please see screenshots attached. It is necessary to add more than 4 sites so that there are more than 9 top sites and the view when tapping on control button is broken.

- Long press on a top site to open it in private mode is not working. Long pressing on the site opens the context menu, but when tapping on Open in New Private Tab option nothing happens

Investigating why the other tests fails. The error is in the assertion when trying to count and compare the sites that there should be. But seems that the problem is that it is not possible to access them. 
Looking at the logs (attached), it seems that app.tables["Top sites"] is not defined.

Changing these lines:

let topSites = app.tables["Top sites"].cells["TopSitesCell"]
let numberOfTopSites = topSites.children(matching: .other).matching(identifier: "TopSite").count

With these ones: 
let topSites = app.cells["TopSitesCell"]
let numberOfTopSites = topSites.cells.matching(identifier: "TopSite").count

Make the tests pass locally. 
Not sure if that is the cause. It is strange because going back to a commit where these tests passed in the past, I can reproduce this issue now locally.

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: topsites2.png

Comment 2

[Isabel Rios[:isabel_rios]]

Attachment: topsites3.png

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: topsites4.png

Comment 4

[Isabel Rios[:isabel_rios]]

Attachment: TopSitesLogs.rtf

Comment 5

[Isabel Rios[:isabel_rios]]

Could you confirm whether there has been a change here so that we have to update the tests? 
And also about the regressions to confirm if they are bugs.

Thanks!

Comment 6

[Farhan Patel [:farhan]]

Yea we changed the Topsites. Some of these regressions are already fixed in a patch I have waiting for review. While the tests specifically I'll fix once changes to the UI stop.

Comment 7

[Isabel Rios[:isabel_rios]]

Thanks! Let me know if you want me to open separate bugs for the different issues or it is fine having them here.
Also, about the tests, I can fix them if you want once the UI work finishes.

Comment 8

[Isabel Rios[:isabel_rios]]

There is a new issue with the new AS (bb 2674 commit: 02467f8):

- Long tapping on a top site and selecting Share does not open the Share menu.

Also one question, should the empty placeholders for new top sites be shown? For example now as default there are five top sites and it is possible to see 3 placeholders for the new top sites' icons. Is that correct?

As AS is an ongoing work you are probably aware of this, but if not and need a bug for it, please let me know.

Thanks!

Comment 9

[Farhan Patel [:farhan]]

That looks like a bug. The share menu doesnt seem to work at all.

Comment 10

[Farhan Patel [:farhan]]

PS. I'm not usually aware of every bug :) Filling a bug is usually a good call. If its a dupe/invalid we can always close it. But at least then it wont get lost in a comment. And someone else can pick it up if I don't get a chance.

Comment 11

[Isabel Rios[:isabel_rios]]

Thanks! Already filed a bug 1357108 for that.

And yeah, I know, sorry, just wanted to avoid creating a bug that you were already working on :)

Comment 12

[Farhan Patel [:farhan]]

I think all the regressions mentioned in this bug are fixed. We could open a new bug for fixing the Activity Stream tests. 

I'm going to close this bug.

Comment 13

[Isabel Rios[:isabel_rios]]

Thanks Farhan, there is already a bug for re-enabling those tests. That is bug 1353432

Comment 14

[Isabel Rios[:isabel_rios]]

There is one of the issues mentioned that is not fixed yet, at least I can still reproduce:
iOS 6 simulator 10.3, commit: 141e476b0b25e1a430cb6599ee22bba0af33f353

- Long press on a top site to open it in private mode is not working. Long pressing on the site opens the context menu, but when tapping on Open in New Private Tab option nothing happens.

I will open a follow up bug for that.